diff options
| author | Genadi Samokovarov <gsamokovarov@gmail.com> | 2015-01-31 20:00:33 +0200 |
|---|---|---|
| committer | Genadi Samokovarov <gsamokovarov@gmail.com> | 2015-02-01 12:00:18 +0200 |
| commit | 872e22c60391dc45b7551cc0698d5530bb310611 (patch) | |
| tree | 9a52aee77d811b48a0e95518330f79582fa9ea13 /actionpack/lib/abstract_controller | |
| parent | ad83233eee3a5beb48919a91b4c109ff8c145f6b (diff) | |
| download | rails-872e22c60391dc45b7551cc0698d5530bb310611.tar.gz rails-872e22c60391dc45b7551cc0698d5530bb310611.tar.bz2 rails-872e22c60391dc45b7551cc0698d5530bb310611.zip | |
Show proper traces on Windows for the error pages
This is an issue brought up by @daniel-rikowski in rails/web-console#91.
Citing his PR proposal here:
> Prior to this, backtrace lines were simply split by a single colon.
>
> Unfortunately that is also the drive letter delimiter in Windows paths
> which resulted in a lot of empty source fragments of "C:0". ("C" from
> the drive letter and 0 from "/path/to/rails/file.rb:16".to_i)
>
> Now the trace line is split by the first colon followed by some digits,
> which works for both Windows and Unix path styles.
Now, the PR was sent against web-console, because of the templates copy
issue we used to had. Instead of bothering the contributor to reopen the
issue against upstream Rails itself, I will make sure he gets the credit
by putting his name in [rails-contributors/hard_coded_authors.rb][].
[rails-contributors/hard_coded_authors.rb]: (https://github.com/fxn/rails-contributors/blob/master/app/models/names_manager/hard_coded_authors.rb).
Diffstat (limited to 'actionpack/lib/abstract_controller')
0 files changed, 0 insertions, 0 deletions