aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/CHANGELOG.md
diff options
context:
space:
mode:
authorAndrew White <andyw@pixeltrix.co.uk>2014-01-05 11:57:50 +0000
committerAndrew White <andyw@pixeltrix.co.uk>2014-01-05 11:57:50 +0000
commit6b548830828e4e910de7854d21717c17303e089c (patch)
treed600f9547a3ac8aa7c646ccaeef6d553319ad5e4 /actionpack/CHANGELOG.md
parent892c539591c001285792b7865fe5d70846b0041b (diff)
downloadrails-6b548830828e4e910de7854d21717c17303e089c.tar.gz
rails-6b548830828e4e910de7854d21717c17303e089c.tar.bz2
rails-6b548830828e4e910de7854d21717c17303e089c.zip
Unique the segment keys array for non-optimized url helpers
In Rails 3.2 you only needed pass an argument for dynamic segment once so unique the segment keys array to match the number of args. Since the number of args is less than required parts the non-optimized code path is selected. This means to benefit from optimized url generation the arg needs to be specified as many times as it appears in the path. Fixes #12808
Diffstat (limited to 'actionpack/CHANGELOG.md')
-rw-r--r--actionpack/CHANGELOG.md12
1 files changed, 12 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
index dc627a4da4..bf608e162b 100644
--- a/actionpack/CHANGELOG.md
+++ b/actionpack/CHANGELOG.md
@@ -1,3 +1,15 @@
+* Unique the segment keys array for non-optimized url helpers
+
+ In Rails 3.2 you only needed pass an argument for dynamic segment once so
+ unique the segment keys array to match the number of args. Since the number
+ of args is less than required parts the non-optimized code path is selected.
+ This means to benefit from optimized url generation the arg needs to be
+ specified as many times as it appears in the path.
+
+ Fixes #12808
+
+ *Andrew White*
+
* Show full route constraints in error message
When an optimized helper fails to generate, show the full route constraints