diff options
author | Dillon Welch <daw0328@gmail.com> | 2018-03-29 19:29:55 -0700 |
---|---|---|
committer | Dillon Welch <daw0328@gmail.com> | 2018-07-23 15:37:06 -0700 |
commit | d108288c2f684233298f97f18ac00de0b016deaa (patch) | |
tree | 0656fd6f20d662d854a3fc93e80dfbc0baec063d /actionmailer | |
parent | a4398e412c042b297039cc216f6536b0c048bd9c (diff) | |
download | rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.gz rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.bz2 rails-d108288c2f684233298f97f18ac00de0b016deaa.zip |
Turn on performance based cops
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
Diffstat (limited to 'actionmailer')
-rw-r--r-- | actionmailer/lib/action_mailer/inline_preview_interceptor.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/actionmailer/lib/action_mailer/inline_preview_interceptor.rb b/actionmailer/lib/action_mailer/inline_preview_interceptor.rb index 8a12f805cc..2b97ac5b94 100644 --- a/actionmailer/lib/action_mailer/inline_preview_interceptor.rb +++ b/actionmailer/lib/action_mailer/inline_preview_interceptor.rb @@ -40,9 +40,7 @@ module ActionMailer end private - def message - @message - end + attr_reader :message def html_part @html_part ||= message.html_part |