aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer/test/url_test.rb
diff options
context:
space:
mode:
authorCameron Cundiff <github@ckundo.com>2017-08-16 14:34:02 -0400
committerCameron Cundiff <github@ckundo.com>2017-08-17 16:13:15 -0400
commit9a74c7b99bf0ac901f86bb38372a68e157cf9c73 (patch)
tree35baa306f1853c73aeb1088fa1fbfda5ea8e0d13 /actionmailer/test/url_test.rb
parentd2f493c7ed7a95f48730aecdcfbcc7bbee30921b (diff)
downloadrails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.gz
rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.bz2
rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.zip
Do not generate default alt text in image tags
- Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
Diffstat (limited to 'actionmailer/test/url_test.rb')
-rw-r--r--actionmailer/test/url_test.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/actionmailer/test/url_test.rb b/actionmailer/test/url_test.rb
index 0bd3371878..82035689ad 100644
--- a/actionmailer/test/url_test.rb
+++ b/actionmailer/test/url_test.rb
@@ -121,7 +121,7 @@ class ActionMailerUrlTest < ActionMailer::TestCase
expected = new_mail
expected.to = @recipient
expected.subject = "[Signed up] Welcome #{@recipient}"
- expected.body = "Hello there,\n\nMr. #{@recipient}. Please see our greeting at http://example.com/welcome/greeting http://www.basecamphq.com/welcome\n\n<img alt=\"Somelogo\" src=\"/images/somelogo.png\" />"
+ expected.body = "Hello there,\n\nMr. #{@recipient}. Please see our greeting at http://example.com/welcome/greeting http://www.basecamphq.com/welcome\n\n<img src=\"/images/somelogo.png\" />"
expected.from = "system@loudthinking.com"
expected.date = Time.local(2004, 12, 12)
expected.content_type = "text/html"