diff options
| author | João Britto <jabcalves@gmail.com> | 2013-12-16 00:51:35 -0200 |
|---|---|---|
| committer | João Britto <jabcalves@gmail.com> | 2014-01-09 20:36:59 -0200 |
| commit | c2afa055614f15edfbd2f4c97f9254425286fc6e (patch) | |
| tree | 9542a703d05740c39e12891f22420f369e7c3a47 /actionmailer/test/mailers | |
| parent | da65fe9e11b7f445847228753e6df46d376e29ab (diff) | |
| download | rails-c2afa055614f15edfbd2f4c97f9254425286fc6e.tar.gz rails-c2afa055614f15edfbd2f4c97f9254425286fc6e.tar.bz2 rails-c2afa055614f15edfbd2f4c97f9254425286fc6e.zip | |
Improve ERB dependency detection.
The current implementation can't handle some special cases of oddly-formatted Ruby. Now we are able to detect them:
* Multi-line arguments on the `render` call
* Strings containing quotes, e.g. `"something's wrong"`
* Multiple kinds of identifiers - instance variables, class variables and globals
* Method chains as arguments for the `render` call
Also, this fix reduces the rate of "false positives" which showed up when we had calls/access to identifiers containing `render`, like `surrender` and `rendering`.
Diffstat (limited to 'actionmailer/test/mailers')
0 files changed, 0 insertions, 0 deletions