aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer/test/base_test.rb
diff options
context:
space:
mode:
authorCameron Cundiff <github@ckundo.com>2017-08-16 14:34:02 -0400
committerCameron Cundiff <github@ckundo.com>2017-08-17 16:13:15 -0400
commit9a74c7b99bf0ac901f86bb38372a68e157cf9c73 (patch)
tree35baa306f1853c73aeb1088fa1fbfda5ea8e0d13 /actionmailer/test/base_test.rb
parentd2f493c7ed7a95f48730aecdcfbcc7bbee30921b (diff)
downloadrails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.gz
rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.bz2
rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.zip
Do not generate default alt text in image tags
- Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
Diffstat (limited to 'actionmailer/test/base_test.rb')
-rw-r--r--actionmailer/test/base_test.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/actionmailer/test/base_test.rb b/actionmailer/test/base_test.rb
index d029329497..0da969c349 100644
--- a/actionmailer/test/base_test.rb
+++ b/actionmailer/test/base_test.rb
@@ -578,7 +578,7 @@ class BaseTest < ActiveSupport::TestCase
mail = AssetMailer.welcome
- assert_dom_equal(%{<img alt="Dummy" src="http://global.com/images/dummy.png" />}, mail.body.to_s.strip)
+ assert_dom_equal(%{<img src="http://global.com/images/dummy.png" />}, mail.body.to_s.strip)
end
test "assets tags should use a Mailer's asset_host settings when available" do
@@ -592,7 +592,7 @@ class BaseTest < ActiveSupport::TestCase
mail = TempAssetMailer.welcome
- assert_dom_equal(%{<img alt="Dummy" src="http://local.com/images/dummy.png" />}, mail.body.to_s.strip)
+ assert_dom_equal(%{<img src="http://local.com/images/dummy.png" />}, mail.body.to_s.strip)
end
test "the view is not rendered when mail was never called" do