Remove ActionMailer helpers and rely on AbstractController one.

2 files changed, 14 insertions, 130 deletions

diff --git a/actionmailer/lib/action_mailer/base.rb b/actionmailer/lib/action_mailer/base.rb
index 29afa2692a..d01120d0d8 100644
--- a/actionmailer/lib/action_mailer/base.rb
+++ b/actionmailer/lib/action_mailer/base.rb
@@ -256,6 +256,9 @@ module ActionMailer #:nodoc:
     include AbstractController::RenderingController
     include AbstractController::Layouts
 
+    include AbstractController::Helpers
+    helper MailHelper
+
     if Object.const_defined?(:ActionController)
       include ActionController::UrlWriter
     end
@@ -442,6 +445,7 @@ module ActionMailer #:nodoc:
         self.view_paths && self.view_paths.first
       end
 
+      # Should template root overwrite the whole view_paths?
       def template_root=(root)
         self.view_paths = ActionView::Base.process_view_paths(root)
       end
@@ -470,6 +474,11 @@ module ActionMailer #:nodoc:
 
         # If an explicit, textual body has not been set, we check assumptions.
         unless String === @body
+          # TODO Hax
+          @body.each do |k, v|
+            instance_variable_set(:"@#{k}", v)
+          end
+
           # First, we look to see if there are any likely templates that match,
           # which include the content-type in their file name (i.e.,
           # "the_template_file.text.html.erb", etc.). Only do this if parts
@@ -480,7 +489,7 @@ module ActionMailer #:nodoc:
                 :content_type => template.mime_type ? template.mime_type.to_s : "text/plain",
                 :disposition => "inline",
                 :charset => charset,
-                :body => render_template(template, @body)
+                :body => render_to_string(:_template => template)
               )
             end
 
@@ -562,16 +571,10 @@ module ActionMailer #:nodoc:
         @sent_on ||= Time.now
       end
 
-      def render_template(template, body)
-        if template.respond_to?(:mime_type)
-          @current_template_content_type = template.mime_type && template.mime_type.to_sym.to_s
-        end
-        
-        @template = initialize_template_class(body)
-        layout = _layout_for_option(:default, :formats => formats)
-        @template._render_template(template, layout, {})
-      ensure
-        @current_template_content_type = nil
+      def _determine_template(options)
+        super
+        layout = options.key?(:layout) ? options[:layout] : :default
+        options[:_layout] = _layout_for_option(layout, options[:_template].details)
       end
 
       def render_message(method_name, body)
@@ -701,9 +704,4 @@ module ActionMailer #:nodoc:
       end
 
   end
-
-  Base.class_eval do
-    include Helpers
-    helper MailHelper
-  end
 end
diff --git a/actionmailer/lib/action_mailer/helpers.rb b/actionmailer/lib/action_mailer/helpers.rb
deleted file mode 100644
index ecd8f0f5b6..0000000000
--- a/actionmailer/lib/action_mailer/helpers.rb
+++ /dev/null
@@ -1,114 +0,0 @@
-require 'active_support/dependencies'
-
-module ActionMailer
-  module Helpers #:nodoc:
-    def self.included(base) #:nodoc:
-      # Initialize the base module to aggregate its helpers.
-      base.class_inheritable_accessor :master_helper_module
-      base.master_helper_module = Module.new
-
-      # Extend base with class methods to declare helpers.
-      base.extend(ClassMethods)
-
-      base.class_eval do
-        # Wrap inherited to create a new master helper module for subclasses.
-        class << self
-          alias_method_chain :inherited, :helper
-        end
-
-        # Wrap initialize_template_class to extend new template class
-        # instances with the master helper module.
-        alias_method_chain :initialize_template_class, :helper
-      end
-    end
-
-    module ClassMethods
-      # Makes all the (instance) methods in the helper module available to templates rendered through this controller.
-      # See ActionView::Helpers (link:classes/ActionView/Helpers.html) for more about making your own helper modules
-      # available to the templates.
-      def add_template_helper(helper_module) #:nodoc:
-        master_helper_module.module_eval "include #{helper_module}"
-      end
-
-      # Declare a helper:
-      #   helper :foo
-      # requires 'foo_helper' and includes FooHelper in the template class.
-      #   helper FooHelper
-      # includes FooHelper in the template class.
-      #   helper { def foo() "#{bar} is the very best" end }
-      # evaluates the block in the template class, adding method +foo+.
-      #   helper(:three, BlindHelper) { def mice() 'mice' end }
-      # does all three.
-      def helper(*args, &block)
-        args.flatten.each do |arg|
-          case arg
-            when Module
-              add_template_helper(arg)
-            when String, Symbol
-              file_name  = arg.to_s.underscore + '_helper'
-              class_name = file_name.camelize
-
-              require_dependency(file_name, "Missing helper file helpers/%s.rb")
-              # begin
-              #   require_dependency(file_name)
-              # rescue LoadError => load_error
-              #   requiree = / -- (.*?)(\.rb)?$/.match(load_error.message).to_a[1]
-              #   msg = (requiree == file_name) ? "Missing helper file helpers/#{file_name}.rb" : "Can't load file: #{requiree}"
-              #   raise LoadError.new(msg).copy_blame!(load_error)
-              # end
-
-              add_template_helper(class_name.constantize)
-            else
-              raise ArgumentError, 'helper expects String, Symbol, or Module argument'
-          end
-        end
-
-        # Evaluate block in template class if given.
-        master_helper_module.module_eval(&block) if block_given?
-      end
-
-      # Declare a controller method as a helper.  For example,
-      #   helper_method :link_to
-      #   def link_to(name, options) ... end
-      # makes the link_to controller method available in the view.
-      def helper_method(*methods)
-        methods.flatten.each do |method|
-          master_helper_module.module_eval <<-end_eval
-            def #{method}(*args, &block)
-              controller.__send__(%(#{method}), *args, &block)
-            end
-          end_eval
-        end
-      end
-
-      # Declare a controller attribute as a helper.  For example,
-      #   helper_attr :name
-      #   attr_accessor :name
-      # makes the name and name= controller methods available in the view.
-      # The is a convenience wrapper for helper_method.
-      def helper_attr(*attrs)
-        attrs.flatten.each { |attr| helper_method(attr, "#{attr}=") }
-      end
-
-      private
-        def inherited_with_helper(child)
-          inherited_without_helper(child)
-          begin
-            child.master_helper_module = Module.new
-            child.master_helper_module.__send__(:include, master_helper_module)
-            child.helper child.name.to_s.underscore
-          rescue MissingSourceFile => e
-            raise unless e.is_missing?("#{child.name.to_s.underscore}_helper")
-          end
-        end
-    end
-
-    private
-      # Extend the template class instance with our controller's helper module.
-      def initialize_template_class_with_helper(assigns)
-        initialize_template_class_without_helper(assigns).tap do |template|
-          template.extend self.class.master_helper_module
-        end
-      end
-  end
-end