diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2017-07-24 09:50:11 +0900 |
---|---|---|
committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-01-18 16:01:07 +0900 |
commit | 31ffbf8d5056137717da3f11d28c4fbd7fbc8f07 (patch) | |
tree | 3b8d6a2d9329a91178d358f0e45c7ec6b13362ee /actionmailbox | |
parent | 5b6daff5b6d5439e07c058718069f54b34970f93 (diff) | |
download | rails-31ffbf8d5056137717da3f11d28c4fbd7fbc8f07.tar.gz rails-31ffbf8d5056137717da3f11d28c4fbd7fbc8f07.tar.bz2 rails-31ffbf8d5056137717da3f11d28c4fbd7fbc8f07.zip |
All of queries should return correct result even if including large number
Currently several queries cannot return correct result due to incorrect
`RangeError` handling.
First example:
```ruby
assert_equal true, Topic.where(id: [1, 9223372036854775808]).exists?
assert_equal true, Topic.where.not(id: 9223372036854775808).exists?
```
The first example is obviously to be true, but currently it returns
false.
Second example:
```ruby
assert_equal topics(:first), Topic.where(id: 1..9223372036854775808).find(1)
```
The second example also should return the object, but currently it
raises `RecordNotFound`.
It can be seen from the examples, the queries including large number
assuming empty result is not always correct.
Therefore, This change handles `RangeError` to generate executable SQL
instead of raising `RangeError` to users to always return correct
result. By this change, it is no longer raised `RangeError` to users.
Diffstat (limited to 'actionmailbox')
0 files changed, 0 insertions, 0 deletions