diff options
author | Ryan Castner <audiolion@users.noreply.github.com> | 2019-03-31 13:41:12 -0400 |
---|---|---|
committer | Kasper Timm Hansen <kaspth@gmail.com> | 2019-03-31 19:41:12 +0200 |
commit | 6d488a22d361d19e3de98c603d98e64ccea8a2f3 (patch) | |
tree | 45eb50ca88b0cc1e14f94c5eefd6a97eb901451c /actioncable/test/javascript | |
parent | ba4e74e1b73437cce08e319286103e025f7cc803 (diff) | |
download | rails-6d488a22d361d19e3de98c603d98e64ccea8a2f3.tar.gz rails-6d488a22d361d19e3de98c603d98e64ccea8a2f3.tar.bz2 rails-6d488a22d361d19e3de98c603d98e64ccea8a2f3.zip |
feat(js): Dynamic ActionCable URL (#35579)
* Failing test case
* feat: Dynamic Url Generation
Change createWebSocketURL to be a closure that allows url to be evaluated at the time the webSocket is established
* refactor: createWebSocketURL to Consumer, remove need for closure
Move initial call to createWebSocketURL in createConsumer
* docs: Add documentation for dynamic url and string args to createConsumer
Co-Authored-By: rmacklin <rmacklin@users.noreply.github.com>
[Ryan Castner, rmacklin]
Diffstat (limited to 'actioncable/test/javascript')
-rw-r--r-- | actioncable/test/javascript/src/unit/action_cable_test.js | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/actioncable/test/javascript/src/unit/action_cable_test.js b/actioncable/test/javascript/src/unit/action_cable_test.js index c9d34abc6d..2181f955e3 100644 --- a/actioncable/test/javascript/src/unit/action_cable_test.js +++ b/actioncable/test/javascript/src/unit/action_cable_test.js @@ -43,11 +43,14 @@ module("ActionCable", () => { }) test("uses function to generate URL", assert => { + let dynamicURL = testURL const generateURL = () => { - return testURL + return dynamicURL } + + dynamicURL = `${testURL}foo` const consumer = ActionCable.createConsumer(generateURL) - assert.equal(consumer.url, testURL) + assert.equal(consumer.url, `${testURL}foo`) }) }) }) |