aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib/action_cable/server/connections.rb
diff options
context:
space:
mode:
authorJon Moss <me@jonathanmoss.me>2016-02-16 12:20:03 -0500
committerJon Moss <me@jonathanmoss.me>2016-02-18 16:26:17 -0500
commitcefcc0f66e185b808fc93040b1d7805f95bf929f (patch)
tree3ad1cc881186995317d3c64d86b56c669aa9e588 /actioncable/lib/action_cable/server/connections.rb
parent9671df3ff797347940da2e813d005a4584ef464e (diff)
downloadrails-cefcc0f66e185b808fc93040b1d7805f95bf929f.tar.gz
rails-cefcc0f66e185b808fc93040b1d7805f95bf929f.tar.bz2
rails-cefcc0f66e185b808fc93040b1d7805f95bf929f.zip
Fix `unsubscribed` server side behavior
Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
Diffstat (limited to 'actioncable/lib/action_cable/server/connections.rb')
0 files changed, 0 insertions, 0 deletions