diff options
author | Richard Macklin <richard.github@nrm.com> | 2018-10-18 22:00:06 -0700 |
---|---|---|
committer | Richard Macklin <richard.github@nrm.com> | 2019-01-14 17:44:35 -0800 |
commit | ac8ffbe76a90d89a5655bea6af5abcac6c7320e0 (patch) | |
tree | 0b9a0d21d7e04c56d15d899f479740a3d6f444c5 /actioncable/app | |
parent | fcd38cf19fa6249d5b62bbe887fde6120408e9c3 (diff) | |
download | rails-ac8ffbe76a90d89a5655bea6af5abcac6c7320e0.tar.gz rails-ac8ffbe76a90d89a5655bea6af5abcac6c7320e0.tar.bz2 rails-ac8ffbe76a90d89a5655bea6af5abcac6c7320e0.zip |
Replace `window` references in ActionCable with `self`
Before this change, attempting to use ActionCable inside a web worker
would result in an exception being thrown:
```
ReferenceError: window is not defined
```
By replacing the `window` reference with `self`, which is available in
both a window context and a worker context, we can avoid this error.
Ref:
https://developer.mozilla.org/en-US/docs/Web/API/Window/self
Diffstat (limited to 'actioncable/app')
-rw-r--r-- | actioncable/app/assets/javascripts/action_cable.js | 4 | ||||
-rw-r--r-- | actioncable/app/javascript/action_cable/adapters.js | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/actioncable/app/assets/javascripts/action_cable.js b/actioncable/app/assets/javascripts/action_cable.js index a68c76f299..2b51eadb9e 100644 --- a/actioncable/app/assets/javascripts/action_cable.js +++ b/actioncable/app/assets/javascripts/action_cable.js @@ -3,8 +3,8 @@ })(this, function(exports) { "use strict"; var adapters = { - logger: window.console, - WebSocket: window.WebSocket + logger: self.console, + WebSocket: self.WebSocket }; var logger = { log: function log() { diff --git a/actioncable/app/javascript/action_cable/adapters.js b/actioncable/app/javascript/action_cable/adapters.js index 9ba6d338ee..4de8131438 100644 --- a/actioncable/app/javascript/action_cable/adapters.js +++ b/actioncable/app/javascript/action_cable/adapters.js @@ -1,4 +1,4 @@ export default { - logger: window.console, - WebSocket: window.WebSocket + logger: self.console, + WebSocket: self.WebSocket } |