aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/app/javascript/action_cable
diff options
context:
space:
mode:
authorJavan Makhmali <javan@javan.us>2019-01-16 17:10:57 -0500
committerGitHub <noreply@github.com>2019-01-16 17:10:57 -0500
commit481192171e67c2aad1dc4a3de113a61cca231674 (patch)
tree23f8e7d729a9b089c745fdee2bf7eafb25216e21 /actioncable/app/javascript/action_cable
parenta5fee7d531c06176ecc8815f52d9d54050c274ce (diff)
parent39493185d315162933cd60cdecc8643c98ed845d (diff)
downloadrails-481192171e67c2aad1dc4a3de113a61cca231674.tar.gz
rails-481192171e67c2aad1dc4a3de113a61cca231674.tar.bz2
rails-481192171e67c2aad1dc4a3de113a61cca231674.zip
Merge pull request #34941 from rmacklin/allow-actioncable-to-run-in-web-workers
Avoid ReferenceError exceptions if ActionCable is used in a web worker
Diffstat (limited to 'actioncable/app/javascript/action_cable')
-rw-r--r--actioncable/app/javascript/action_cable/adapters.js4
-rw-r--r--actioncable/app/javascript/action_cable/connection_monitor.js4
2 files changed, 4 insertions, 4 deletions
diff --git a/actioncable/app/javascript/action_cable/adapters.js b/actioncable/app/javascript/action_cable/adapters.js
index 9ba6d338ee..4de8131438 100644
--- a/actioncable/app/javascript/action_cable/adapters.js
+++ b/actioncable/app/javascript/action_cable/adapters.js
@@ -1,4 +1,4 @@
export default {
- logger: window.console,
- WebSocket: window.WebSocket
+ logger: self.console,
+ WebSocket: self.WebSocket
}
diff --git a/actioncable/app/javascript/action_cable/connection_monitor.js b/actioncable/app/javascript/action_cable/connection_monitor.js
index f0e75ae137..312a71d154 100644
--- a/actioncable/app/javascript/action_cable/connection_monitor.js
+++ b/actioncable/app/javascript/action_cable/connection_monitor.js
@@ -21,7 +21,7 @@ class ConnectionMonitor {
this.startedAt = now()
delete this.stoppedAt
this.startPolling()
- document.addEventListener("visibilitychange", this.visibilityDidChange)
+ addEventListener("visibilitychange", this.visibilityDidChange)
logger.log(`ConnectionMonitor started. pollInterval = ${this.getPollInterval()} ms`)
}
}
@@ -30,7 +30,7 @@ class ConnectionMonitor {
if (this.isRunning()) {
this.stoppedAt = now()
this.stopPolling()
- document.removeEventListener("visibilitychange", this.visibilityDidChange)
+ removeEventListener("visibilitychange", this.visibilityDidChange)
logger.log("ConnectionMonitor stopped")
}
}