diff options
author | John Hawthorn <john@hawthorn.email> | 2019-04-11 17:14:16 -0700 |
---|---|---|
committer | John Hawthorn <john@hawthorn.email> | 2019-04-12 12:30:26 -0700 |
commit | 1fc735e5f584b481eba85670c519731271ac1796 (patch) | |
tree | 3d5b24cc0817371166ba6467501fa9ca1719118c /actioncable/.eslintrc | |
parent | 80e2aaa80afc205d223288b85828729cb181f6f2 (diff) | |
download | rails-1fc735e5f584b481eba85670c519731271ac1796.tar.gz rails-1fc735e5f584b481eba85670c519731271ac1796.tar.bz2 rails-1fc735e5f584b481eba85670c519731271ac1796.zip |
De-dup Templates, introduce UnboundTemplate
Previously it's possible to have multiple copies of the "same" Template.
For example, if index.html.erb is found both the :en and :fr locale, it
will return a different Template object for each. The same can happen
with formats, variants, and handlers.
This commit de-duplicates templates, there will now only be one template
per file/virtual_path/locals tuple.
We need to consider virtual_path because both `render "index"`, and
`render "index.html"` can both find the same file but will have
different virtual_paths. IMO this is rare and should be
deprecated/removed, but it exists now so we need to consider it in order
to cache correctly.
This commit introduces a new UnboundTemplate class, which represents a
template with unknown locals. Template objects can be built from it by
using `#with_locals`. Currently, this is just a convenience around
caching templates, but I hope it's a helpful concept that could have
more utility in the future.
Diffstat (limited to 'actioncable/.eslintrc')
0 files changed, 0 insertions, 0 deletions