diff options
author | Nick Kallen <nkallen@nick-kallens-computer-2.local> | 2008-03-11 23:39:40 -0700 |
---|---|---|
committer | Nick Kallen <nkallen@nick-kallens-computer-2.local> | 2008-03-11 23:39:40 -0700 |
commit | 8a62a733c107a33edee8cabc908c3ebc3b280e8b (patch) | |
tree | 30d088f5ef2798ee164fb6fe4ea253cef20b3f19 /TODO | |
parent | 12ef6a5ad15078d2f634d3c6cdfc453848f90122 (diff) | |
download | rails-8a62a733c107a33edee8cabc908c3ebc3b280e8b.tar.gz rails-8a62a733c107a33edee8cabc908c3ebc3b280e8b.tar.bz2 rails-8a62a733c107a33edee8cabc908c3ebc3b280e8b.zip |
renamed strategy method to format
- strategy (the method on scalar and attribute) is a complex double-dispatching
scheme to format (to_sql) a scalar in the light of the particular attribute;
that is, it casts strings to integers if the column is int, etc.
Diffstat (limited to 'TODO')
-rw-r--r-- | TODO | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -1,6 +1,5 @@ todo: - clarify distinction between engine and connection: an engine is a connection pool, plus the quoting operations -- #relation is now on scalar, attribute and relation; you must admit it's name is confusing given that e.g., relation already has a strategy (Sql::Relation) ... should it be called predicate strategy? operand1.to_sql(operand2.predicate) maybe prefer operand1.cast(operand2) or project or in light of - clean up integration tests in join - i find the aggregate stuff too integrationy; unit testing would be better - test relation, table reset - cache expiry on write @@ -46,3 +45,5 @@ done: - hash custom matcher - make session engine stuff follow laws of demeter - currently doing some odd method chaining? rethink who is responsible for what - session just calls execute, passing in a connection; by default it gets a connection from the relation. +- #strategy is now on scalar, attribute and relation; you must admit it's name is confusing given that e.g., relation already has a strategy (Sql::Relation) ... should it be called predicate strategy? operand1.to_sql(operand2.predicate) maybe prefer operand1.cast(operand2) or project or in light of + - renamed to #format: operand1.format(operand2) |