diff options
author | Sean Griffin <sean@thoughtbot.com> | 2014-11-26 13:45:31 -0700 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2014-11-29 16:08:51 -0700 |
commit | 7508284800f67b4611c767bff9eae7045674b66f (patch) | |
tree | 9f16f258662c4b0165f1ee255eddb3f07d6aeeb6 /README.markdown | |
parent | ec083687a96af1f35f9fb9e75611cc4bf4f5bf81 (diff) | |
download | rails-7508284800f67b4611c767bff9eae7045674b66f.tar.gz rails-7508284800f67b4611c767bff9eae7045674b66f.tar.bz2 rails-7508284800f67b4611c767bff9eae7045674b66f.zip |
Remove engine from the constructor arguments `Arel::Table`
It is never used outside of convenience methods which are only used in
tests. In practice, it just made constructing tables more complicated on
the rails side. This is the minimum possible change to remove the
constructor argument, but continue to have the tests passing.
I'm not sure if we have a reason to keep `project` and friends, and the
solution might actually just be to remove the engine from
`SelectManager` and friends. As such I've held off on deleting those
methods.
We need to figure out what to do with `Table#from`. It's old invocation,
which read `table.from(table)` was certainly nonsensical.
Diffstat (limited to 'README.markdown')
0 files changed, 0 insertions, 0 deletions