diff options
| author | Francesco Rodriguez <frodsan@protonmail.com> | 2017-09-25 14:06:15 +0200 |
|---|---|---|
| committer | Francesco Rodriguez <frodsan@protonmail.com> | 2017-09-25 17:07:00 +0200 |
| commit | ff56fdb08d643b8d9892763c4b9731e0391260fd (patch) | |
| tree | 77fb2c91137b6bac2d539821f064d811696ebaa5 | |
| parent | ab08f33f312c20638b9a7c38ee6318727c7f107d (diff) | |
| download | rails-ff56fdb08d643b8d9892763c4b9731e0391260fd.tar.gz rails-ff56fdb08d643b8d9892763c4b9731e0391260fd.tar.bz2 rails-ff56fdb08d643b8d9892763c4b9731e0391260fd.zip | |
Preload digest/sha2 to avoid thread safe error.
I got this error in production using Puma in multi-threaded mode:
```
RuntimeError: Digest::Base cannot be directly inherited in Ruby
from active_support/security_utils.rb:23:in `variable_size_secure_compare'
from active_support/security_utils.rb:23:in `hexdigest'
from active_support/security_utils.rb:23:in `digest'
```
Looks like Digest uses const_missing to load Digest::SHA256 (https://github.com/ruby/ruby/blob/trunk/ext/digest/lib/digest.rb#L8)
- https://bugs.ruby-lang.org/issues/9494
- https://github.com/ruby/ruby/commit/c02fa39463a0c6bf698b01bc610135604aca2ff4
| -rw-r--r-- | activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb | 2 | ||||
| -rw-r--r-- | activesupport/lib/active_support/security_utils.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb index c9607df28c..4f0c1890be 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb @@ -2,7 +2,7 @@ require_relative "../../migration/join_table" require "active_support/core_ext/string/access" -require "digest" +require "digest/sha2" module ActiveRecord module ConnectionAdapters # :nodoc: diff --git a/activesupport/lib/active_support/security_utils.rb b/activesupport/lib/active_support/security_utils.rb index 51870559ec..b6b31ef140 100644 --- a/activesupport/lib/active_support/security_utils.rb +++ b/activesupport/lib/active_support/security_utils.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -require "digest" +require "digest/sha2" module ActiveSupport module SecurityUtils |