diff options
author | Alexey Vakhov <vakhov@gmail.com> | 2011-09-02 18:20:10 +0400 |
---|---|---|
committer | Alexey Vakhov <vakhov@gmail.com> | 2011-09-02 18:20:10 +0400 |
commit | fddf7ea1c1e520f33fa26fe340f3fc107bcc95c8 (patch) | |
tree | 266b1d2beda7a81a712efe1e9ce9b47a7aca0465 | |
parent | 6f3c6992c529a09c8f8bfdb1f714bb8ff1e23300 (diff) | |
download | rails-fddf7ea1c1e520f33fa26fe340f3fc107bcc95c8.tar.gz rails-fddf7ea1c1e520f33fa26fe340f3fc107bcc95c8.tar.bz2 rails-fddf7ea1c1e520f33fa26fe340f3fc107bcc95c8.zip |
current_page? returns false for non-GET requests
-rw-r--r-- | actionpack/lib/action_view/helpers/url_helper.rb | 8 | ||||
-rw-r--r-- | actionpack/test/template/url_helper_test.rb | 10 |
2 files changed, 16 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/helpers/url_helper.rb b/actionpack/lib/action_view/helpers/url_helper.rb index 4dbb0135f6..5a043846a7 100644 --- a/actionpack/lib/action_view/helpers/url_helper.rb +++ b/actionpack/lib/action_view/helpers/url_helper.rb @@ -569,6 +569,12 @@ module ActionView # # current_page?(:controller => 'library', :action => 'checkout') # # => false + # + # Let's say we're in the <tt>/products</tt> action with method POST in case of invalid product. + # + # current_page?(:controller => 'product', :action => 'index') + # # => false + # def current_page?(options) unless request raise "You cannot use helpers that need to determine the current " \ @@ -576,6 +582,8 @@ module ActionView "in a #request method" end + return false unless request.get? + url_string = url_for(options) # We ignore any extra parameters in the request_uri if the diff --git a/actionpack/test/template/url_helper_test.rb b/actionpack/test/template/url_helper_test.rb index 78245c1f95..dbac2e1fc0 100644 --- a/actionpack/test/template/url_helper_test.rb +++ b/actionpack/test/template/url_helper_test.rb @@ -304,8 +304,8 @@ class UrlHelperTest < ActiveSupport::TestCase assert_equal "Showing", link_to_if(false, "Showing", url_hash) end - def request_for_url(url) - env = Rack::MockRequest.env_for("http://www.example.com#{url}") + def request_for_url(url, opts = {}) + env = Rack::MockRequest.env_for("http://www.example.com#{url}", opts) ActionDispatch::Request.new(env) end @@ -329,6 +329,12 @@ class UrlHelperTest < ActiveSupport::TestCase assert current_page?("http://www.example.com/?order=desc&page=1") end + def test_current_page_with_not_get_verb + @request = request_for_url("/events", :method => :post) + + assert !current_page?('/events') + end + def test_link_unless_current @request = request_for_url("/") |