aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEloy Duran <eloy.de.enige@gmail.com>2010-01-02 14:59:29 +0100
committerEloy Duran <eloy.de.enige@gmail.com>2010-01-07 13:19:48 +0100
commitfc6aae34597bbecaf441571b20ab861b021ea8a5 (patch)
tree6490217d5f1dd26cd64fe2bcca28ed1337148b14
parenta559260e41170397ec940321f12853ccdb440993 (diff)
downloadrails-fc6aae34597bbecaf441571b20ab861b021ea8a5.tar.gz
rails-fc6aae34597bbecaf441571b20ab861b021ea8a5.tar.bz2
rails-fc6aae34597bbecaf441571b20ab861b021ea8a5.zip
Remove deprecated '_delete' option from NestedAttributes.
-rw-r--r--activerecord/lib/active_record/nested_attributes.rb15
-rw-r--r--activerecord/test/cases/nested_attributes_test.rb6
2 files changed, 2 insertions, 19 deletions
diff --git a/activerecord/lib/active_record/nested_attributes.rb b/activerecord/lib/active_record/nested_attributes.rb
index c86c1a9d18..e1e80355c0 100644
--- a/activerecord/lib/active_record/nested_attributes.rb
+++ b/activerecord/lib/active_record/nested_attributes.rb
@@ -264,21 +264,11 @@ module ActiveRecord
marked_for_destruction?
end
- # Deal with deprecated _delete.
- #
- def _delete #:nodoc:
- ActiveSupport::Deprecation.warn "_delete is deprecated in nested attributes. Use _destroy instead."
- _destroy
- end
-
private
# Attribute hash keys that should not be assigned as normal attributes.
# These hash keys are nested attributes implementation details.
- #
- # TODO Remove _delete from UNASSIGNABLE_KEYS when deprecation warning are
- # removed.
- UNASSIGNABLE_KEYS = %w( id _destroy _delete )
+ UNASSIGNABLE_KEYS = %w( id _destroy )
# Assigns the given attributes to the association.
#
@@ -375,8 +365,7 @@ module ActiveRecord
# Determines if a hash contains a truthy _destroy key.
def has_destroy_flag?(hash)
- ConnectionAdapters::Column.value_to_boolean(hash['_destroy']) ||
- ConnectionAdapters::Column.value_to_boolean(hash['_delete']) # TODO Remove after deprecation.
+ ConnectionAdapters::Column.value_to_boolean(hash['_destroy'])
end
# Determines if a new record should be build by checking for
diff --git a/activerecord/test/cases/nested_attributes_test.rb b/activerecord/test/cases/nested_attributes_test.rb
index 1d9b734b02..a5e2fa96f2 100644
--- a/activerecord/test/cases/nested_attributes_test.rb
+++ b/activerecord/test/cases/nested_attributes_test.rb
@@ -82,12 +82,6 @@ class TestNestedAttributesInGeneral < ActiveRecord::TestCase
assert ship._destroy
end
- def test_underscore_delete_is_deprecated
- ActiveSupport::Deprecation.expects(:warn)
- ship = Ship.create!(:name => 'Nights Dirty Lightning')
- ship._delete
- end
-
def test_reject_if_method_without_arguments
Pirate.accepts_nested_attributes_for :ship, :reject_if => :new_record?