diff options
| author | Jeremy Kemper <jeremy@bitsweat.net> | 2012-01-26 20:23:10 -0700 |
|---|---|---|
| committer | Jeremy Kemper <jeremy@bitsweat.net> | 2012-01-26 20:34:04 -0700 |
| commit | faaf694e0f94f422b34774a18b94632baad47bc2 (patch) | |
| tree | 9f48be50efdd651b60fcd983ffcdddcff83587ec | |
| parent | f1baf8f5a4fe0dc98b36380498db747d3be5d316 (diff) | |
| download | rails-faaf694e0f94f422b34774a18b94632baad47bc2.tar.gz rails-faaf694e0f94f422b34774a18b94632baad47bc2.tar.bz2 rails-faaf694e0f94f422b34774a18b94632baad47bc2.zip | |
Disagree with @spastorino, @jonleighton, @tenderlove on 51ccb7f59c83120bf6869f1febfebaec44bcface
Same-level method visibility disappears into the syntax. Indent (and
outdent) emphasize the state change that accompanies the declaration.
All methods following 'private' are private: that's a natural
hierarchy worthy of visual reinforcement.
Outdent, represent! :trollface:
| -rw-r--r-- | railties/guides/source/contributing_to_ruby_on_rails.textile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/railties/guides/source/contributing_to_ruby_on_rails.textile b/railties/guides/source/contributing_to_ruby_on_rails.textile index 0f024d3b0b..aac5e13978 100644 --- a/railties/guides/source/contributing_to_ruby_on_rails.textile +++ b/railties/guides/source/contributing_to_ruby_on_rails.textile @@ -309,7 +309,7 @@ Rails follows a simple set of coding style conventions. * Two spaces, no tabs. * No trailing whitespace. Blank lines should not have any space. -* Do not indent after private/protected. Private/protected should have the same indentation as the methods around. +* Outdent private/protected from method definitions. Same indentation as the class/module. * Prefer +&&+/+||+ over +and+/+or+. * Prefer class << self block over self.method for class methods. * +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+. |