aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2007-09-22 23:10:41 +0000
committerDavid Heinemeier Hansson <david@loudthinking.com>2007-09-22 23:10:41 +0000
commitee45d76df80a86961dd44f8526b0ac97bc98ce60 (patch)
treea9f5e71ae9c650d560d33439a449e4fb1e3b363f
parent1abe5a2dedc25d0dcfdff74c65aebc20ccf3011f (diff)
downloadrails-ee45d76df80a86961dd44f8526b0ac97bc98ce60.tar.gz
rails-ee45d76df80a86961dd44f8526b0ac97bc98ce60.tar.bz2
rails-ee45d76df80a86961dd44f8526b0ac97bc98ce60.zip
Roll back #7578, tests failed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
-rw-r--r--actionpack/lib/action_controller/assertions/response_assertions.rb5
-rw-r--r--actionpack/test/template/url_helper_test.rb10
2 files changed, 3 insertions, 12 deletions
diff --git a/actionpack/lib/action_controller/assertions/response_assertions.rb b/actionpack/lib/action_controller/assertions/response_assertions.rb
index a2831aff67..f45727f508 100644
--- a/actionpack/lib/action_controller/assertions/response_assertions.rb
+++ b/actionpack/lib/action_controller/assertions/response_assertions.rb
@@ -78,8 +78,9 @@ module ActionController
url[key] = value
end
- @response_diff = url[:actual].diff(url[:expected]) if url[:actual]
- msg = build_message(message, "expected a redirect to <?>, found one to <?>, a difference of <?> ", url[:expected], url[:actual], @response_diff)
+ @response_diff = url[:expected].diff(url[:actual]) if url[:actual]
+ msg = build_message(message, "response is not a redirection to all of the options supplied (redirection is <?>), difference: <?>",
+ url[:actual], @response_diff)
assert_block(msg) do
url[:expected].keys.all? do |k|
diff --git a/actionpack/test/template/url_helper_test.rb b/actionpack/test/template/url_helper_test.rb
index 712b827c5c..db1e226a7e 100644
--- a/actionpack/test/template/url_helper_test.rb
+++ b/actionpack/test/template/url_helper_test.rb
@@ -108,16 +108,6 @@ class UrlHelperTest < Test::Unit::TestCase
def test_link_tag_with_query_and_no_name
assert_dom_equal "<a href=\"http://www.example.com?q1=v1&amp;q2=v2\">http://www.example.com?q1=v1&amp;q2=v2</a>", link_to(nil, "http://www.example.com?q1=v1&amp;q2=v2")
end
-
- def test_link_tag_with_back
- @controller.request = RequestMock.new("http://www.example.com/weblog/show", nil, nil, {'HTTP_REFERER' => 'http://www.example.com/referer'})
- assert_dom_equal "<a href=\"http://www.example.com/referer\">go back</a>", link_to('go back', :back)
- end
-
- def test_link_tag_with_back_and_no_referer
- @controller.request = RequestMock.new("http://www.example.com/weblog/show", nil, nil, {})
- assert_dom_equal "<a href=\"javascript:history.back()\">go back</a>", link_to('go back', :back)
- end
def test_link_tag_with_img
assert_dom_equal "<a href=\"http://www.example.com\"><img src='/favicon.jpg' /></a>", link_to("<img src='/favicon.jpg' />", "http://www.example.com")