aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2018-10-26 10:44:47 +0900
committerGitHub <noreply@github.com>2018-10-26 10:44:47 +0900
commite7c44ee43966fa1de87c1d149f322ac3a6384382 (patch)
tree450ee0418240d711764c9aabd3accf56b908adb7
parent3f8b1353c64825fb665f3ab0c06d3616dc56b6fe (diff)
parentbf6dc7a714df06c17709bfb73fa273bf9e8be1c6 (diff)
downloadrails-e7c44ee43966fa1de87c1d149f322ac3a6384382.tar.gz
rails-e7c44ee43966fa1de87c1d149f322ac3a6384382.tar.bz2
rails-e7c44ee43966fa1de87c1d149f322ac3a6384382.zip
Merge pull request #34318 from bogdanvlviv/partly-revert-31819
Partly revert #31819
-rw-r--r--activerecord/test/cases/associations/eager_test.rb26
1 files changed, 0 insertions, 26 deletions
diff --git a/activerecord/test/cases/associations/eager_test.rb b/activerecord/test/cases/associations/eager_test.rb
index ed7715c1e2..b37e59038e 100644
--- a/activerecord/test/cases/associations/eager_test.rb
+++ b/activerecord/test/cases/associations/eager_test.rb
@@ -1618,32 +1618,6 @@ class EagerAssociationTest < ActiveRecord::TestCase
end
end
- # Associations::Preloader#preloaders_on works with hash-like objects
- test "preloading works with an object that responds to :to_hash" do
- CustomHash = Class.new(Hash)
-
- assert_nothing_raised do
- Post.preload(CustomHash.new(comments: [{ author: :essays }])).first
- end
- end
-
- # Associations::Preloader#preloaders_on works with string-like objects
- test "preloading works with an object that responds to :to_str" do
- CustomString = Class.new(String)
-
- assert_nothing_raised do
- Post.preload(CustomString.new("comments")).first
- end
- end
-
- # Associations::Preloader#preloaders_on does not work with ranges
- test "preloading fails when Range is passed" do
- exception = assert_raises(ArgumentError) do
- Post.preload(1..10).first
- end
- assert_equal("1..10 was not recognized for preload", exception.message)
- end
-
private
def find_all_ordered(klass, include = nil)
klass.order("#{klass.table_name}.#{klass.primary_key}").includes(include).to_a