aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-07-25 18:16:21 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-07-25 18:16:21 +0900
commite6b707fe75b756a89ec08c9f2368697452f30c68 (patch)
tree8d82e8c0cd96b21db071c04a3e2b1587ec529204
parentbfb770dbcc8432b8d4c1824be0fb2b1ab1ce5d68 (diff)
downloadrails-e6b707fe75b756a89ec08c9f2368697452f30c68.tar.gz
rails-e6b707fe75b756a89ec08c9f2368697452f30c68.tar.bz2
rails-e6b707fe75b756a89ec08c9f2368697452f30c68.zip
Remove unused `bind_values`
Since https://github.com/rails/rails/commit/213796f, `bind_values` is no longer used from Active Record.
-rw-r--r--lib/arel/tree_manager.rb5
-rw-r--r--test/test_select_manager.rb7
2 files changed, 1 insertions, 11 deletions
diff --git a/lib/arel/tree_manager.rb b/lib/arel/tree_manager.rb
index a8dbb4c87a..0542442404 100644
--- a/lib/arel/tree_manager.rb
+++ b/lib/arel/tree_manager.rb
@@ -7,11 +7,8 @@ module Arel
attr_reader :ast
- attr_accessor :bind_values
-
def initialize
- @ctx = nil
- @bind_values = []
+ @ctx = nil
end
def to_dot
diff --git a/test/test_select_manager.rb b/test/test_select_manager.rb
index 9a49fbcd56..cc7452c239 100644
--- a/test/test_select_manager.rb
+++ b/test/test_select_manager.rb
@@ -10,13 +10,6 @@ module Arel
assert_equal "SELECT FROM 'foo'", manager.to_sql
end
- def test_manager_stores_bind_values
- manager = Arel::SelectManager.new
- assert_equal [], manager.bind_values
- manager.bind_values = [1]
- assert_equal [1], manager.bind_values
- end
-
describe 'backwards compatibility' do
describe 'project' do
it 'accepts symbols as sql literals' do