Merge pull request #36493 from kamipo/remove_unused_attributes_for

Remove unused `Arel::Attributes.for`

4 files changed, 1 insertions, 70 deletions

diff --git a/activerecord/lib/arel.rb b/activerecord/lib/arel.rb
index 361cd915cc..0fc07e1ede 100644
--- a/activerecord/lib/arel.rb
+++ b/activerecord/lib/arel.rb
@@ -12,7 +12,7 @@ require "arel/math"
 require "arel/alias_predication"
 require "arel/order_predications"
 require "arel/table"
-require "arel/attributes"
+require "arel/attributes/attribute"
 
 require "arel/visitors"
 require "arel/collectors/sql_string"
diff --git a/activerecord/lib/arel/attributes.rb b/activerecord/lib/arel/attributes.rb
deleted file mode 100644
index 35d586c948..0000000000
--- a/activerecord/lib/arel/attributes.rb
+++ /dev/null
@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-require "arel/attributes/attribute"
-
-module Arel # :nodoc: all
-  module Attributes
-    ###
-    # Factory method to wrap a raw database +column+ to an Arel Attribute.
-    def self.for(column)
-      case column.type
-      when :string, :text, :binary             then String
-      when :integer                            then Integer
-      when :float                              then Float
-      when :decimal                            then Decimal
-      when :date, :datetime, :timestamp, :time then Time
-      when :boolean                            then Boolean
-      else
-        Undefined
-      end
-    end
-  end
-end
diff --git a/activerecord/lib/arel/visitors/to_sql.rb b/activerecord/lib/arel/visitors/to_sql.rb
index a1aa620f9d..eff7a0d036 100644
--- a/activerecord/lib/arel/visitors/to_sql.rb
+++ b/activerecord/lib/arel/visitors/to_sql.rb
@@ -689,12 +689,6 @@ module Arel # :nodoc: all
           join_name = o.relation.table_alias || o.relation.name
           collector << quote_table_name(join_name) << "." << quote_column_name(o.name)
         end
-        alias :visit_Arel_Attributes_Integer :visit_Arel_Attributes_Attribute
-        alias :visit_Arel_Attributes_Float :visit_Arel_Attributes_Attribute
-        alias :visit_Arel_Attributes_Decimal :visit_Arel_Attributes_Attribute
-        alias :visit_Arel_Attributes_String :visit_Arel_Attributes_Attribute
-        alias :visit_Arel_Attributes_Time :visit_Arel_Attributes_Attribute
-        alias :visit_Arel_Attributes_Boolean :visit_Arel_Attributes_Attribute
 
         def literal(o, collector); collector << o.to_s; end
 
diff --git a/activerecord/test/cases/arel/attributes_test.rb b/activerecord/test/cases/arel/attributes_test.rb
index b00af4bd29..1712633ae9 100644
--- a/activerecord/test/cases/arel/attributes_test.rb
+++ b/activerecord/test/cases/arel/attributes_test.rb
@@ -23,46 +23,5 @@ module Arel
         assert_equal 2, array.uniq.size
       end
     end
-
-    describe "for" do
-      it "deals with unknown column types" do
-        column = Struct.new(:type).new :crazy
-        Attributes.for(column).must_equal Attributes::Undefined
-      end
-
-      it "returns the correct constant for strings" do
-        [:string, :text, :binary].each do |type|
-          column = Struct.new(:type).new type
-          Attributes.for(column).must_equal Attributes::String
-        end
-      end
-
-      it "returns the correct constant for ints" do
-        column = Struct.new(:type).new :integer
-        Attributes.for(column).must_equal Attributes::Integer
-      end
-
-      it "returns the correct constant for floats" do
-        column = Struct.new(:type).new :float
-        Attributes.for(column).must_equal Attributes::Float
-      end
-
-      it "returns the correct constant for decimals" do
-        column = Struct.new(:type).new :decimal
-        Attributes.for(column).must_equal Attributes::Decimal
-      end
-
-      it "returns the correct constant for boolean" do
-        column = Struct.new(:type).new :boolean
-        Attributes.for(column).must_equal Attributes::Boolean
-      end
-
-      it "returns the correct constant for time" do
-        [:date, :datetime, :timestamp, :time].each do |type|
-          column = Struct.new(:type).new type
-          Attributes.for(column).must_equal Attributes::Time
-        end
-      end
-    end
   end
 end