diff options
author | Aaron Patterson <aaron.patterson@gmail.com> | 2010-12-26 19:56:07 -0700 |
---|---|---|
committer | Aaron Patterson <aaron.patterson@gmail.com> | 2010-12-26 19:56:07 -0700 |
commit | cefad1e2139c4bba6e45f3281a6d54394aaeb366 (patch) | |
tree | e88a2612d1f6967b25f9e5a2cbcda7303c7370de | |
parent | 32386f88601ab9c6d4a1a292ed087b896a25fd1f (diff) | |
download | rails-cefad1e2139c4bba6e45f3281a6d54394aaeb366.tar.gz rails-cefad1e2139c4bba6e45f3281a6d54394aaeb366.tar.bz2 rails-cefad1e2139c4bba6e45f3281a6d54394aaeb366.zip |
adding deprecation warning for where_clauses
-rw-r--r-- | History.txt | 3 | ||||
-rw-r--r-- | lib/arel/factory_methods.rb | 4 | ||||
-rw-r--r-- | lib/arel/select_manager.rb | 4 |
3 files changed, 10 insertions, 1 deletions
diff --git a/History.txt b/History.txt index 3984a7aa44..726e246a64 100644 --- a/History.txt +++ b/History.txt @@ -31,6 +31,9 @@ * Arel::Table#primary_key is deprecated and will be removed in 3.0.0 with no replacement. + * Arel::SelectManager#where_clauses is deprecated and will be removed in + 3.0.0 with no replacement. + == 2.0.7 (unreleased) * Bug Fixes diff --git a/lib/arel/factory_methods.rb b/lib/arel/factory_methods.rb index 4899adfdc8..09b82c0555 100644 --- a/lib/arel/factory_methods.rb +++ b/lib/arel/factory_methods.rb @@ -17,5 +17,9 @@ module Arel def create_on expr Nodes::On.new expr end + + def grouping expr + Nodes::Grouping.new expr + end end end diff --git a/lib/arel/select_manager.rb b/lib/arel/select_manager.rb index 55700ab92d..274633c9db 100644 --- a/lib/arel/select_manager.rb +++ b/lib/arel/select_manager.rb @@ -30,7 +30,9 @@ module Arel end def where_clauses - #warn "where_clauses is deprecated" if $VERBOSE + if $VERBOSE + warn "(#{caller.first}) where_clauses is deprecated and will be removed in arel 3.0.0 with no replacement" + end to_sql = Visitors::ToSql.new @engine @ctx.wheres.map { |c| to_sql.accept c } end |