diff options
| author | Edward Rudd <urkle@outoforder.cc> | 2017-09-20 13:00:01 -0400 |
|---|---|---|
| committer | Edward Rudd <urkle@outoforder.cc> | 2019-04-03 18:09:34 -0400 |
| commit | c5efbbbccb8fabb25d95f6c5758225f31b3879ba (patch) | |
| tree | 3e307cb17eb5a2833434260691a7dc47c55a9adf | |
| parent | 2ca056be6f38e20add62bc3d370ae06a8263318b (diff) | |
| download | rails-c5efbbbccb8fabb25d95f6c5758225f31b3879ba.tar.gz rails-c5efbbbccb8fabb25d95f6c5758225f31b3879ba.tar.bz2 rails-c5efbbbccb8fabb25d95f6c5758225f31b3879ba.zip | |
Fix checking for template variants when using the ActionView::FixtureResolver
| -rw-r--r-- | actionview/CHANGELOG.md | 4 | ||||
| -rw-r--r-- | actionview/lib/action_view/testing/resolvers.rb | 4 | ||||
| -rw-r--r-- | actionview/test/template/testing/fixture_resolver_test.rb | 10 |
3 files changed, 16 insertions, 2 deletions
diff --git a/actionview/CHANGELOG.md b/actionview/CHANGELOG.md index abb97804e1..be67aff543 100644 --- a/actionview/CHANGELOG.md +++ b/actionview/CHANGELOG.md @@ -6,6 +6,10 @@ *John Hawthorn* +* Fix `ActionView::FixtureResolver` so that it handles template variants correctly. + + *Edward Rudd* + ## Rails 6.0.0.beta3 (March 11, 2019) ## diff --git a/actionview/lib/action_view/testing/resolvers.rb b/actionview/lib/action_view/testing/resolvers.rb index 11ae9f731c..a97fb71b26 100644 --- a/actionview/lib/action_view/testing/resolvers.rb +++ b/actionview/lib/action_view/testing/resolvers.rb @@ -25,8 +25,8 @@ module ActionView #:nodoc: def query(path, exts, _, locals) query = +"" - EXTENSIONS.each_key do |ext| - query << "(" << exts[ext].map { |e| e && Regexp.escape(".#{e}") }.join("|") << "|)" + EXTENSIONS.each do |ext, prefix| + query << "(" << exts[ext].map { |e| e && Regexp.escape("#{prefix}#{e}") }.join("|") << "|)" end query = /^(#{Regexp.escape(path)})#{query}$/ diff --git a/actionview/test/template/testing/fixture_resolver_test.rb b/actionview/test/template/testing/fixture_resolver_test.rb index afb6686dac..a90440574e 100644 --- a/actionview/test/template/testing/fixture_resolver_test.rb +++ b/actionview/test/template/testing/fixture_resolver_test.rb @@ -17,4 +17,14 @@ class FixtureResolverTest < ActiveSupport::TestCase assert_equal "arbitrary/path", templates.first.virtual_path assert_nil templates.first.format end + + def test_should_match_templates_with_variants + resolver = ActionView::FixtureResolver.new("arbitrary/path.html+variant.erb" => "this text") + templates = resolver.find_all("path", "arbitrary", false, locale: [], formats: [:html], variants: [:variant], handlers: [:erb]) + assert_equal 1, templates.size, "expected one template" + assert_equal "this text", templates.first.source + assert_equal "arbitrary/path", templates.first.virtual_path + assert_equal [:html], templates.first.formats + assert_equal ["variant"], templates.first.variants + end end |