diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-10-14 07:48:45 -0700 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-10-14 07:48:45 -0700 |
commit | c05f9558eebf88a137d606c27f3e0be232e35100 (patch) | |
tree | e6996035b427bb736451e363e03d891256178c91 | |
parent | a11ddbe55fd27f38e0085ee1210947e3d8f47220 (diff) | |
parent | 14575893010add4db926c3e8517c360ea62625c2 (diff) | |
download | rails-c05f9558eebf88a137d606c27f3e0be232e35100.tar.gz rails-c05f9558eebf88a137d606c27f3e0be232e35100.tar.bz2 rails-c05f9558eebf88a137d606c27f3e0be232e35100.zip |
Merge pull request #11833 from vipulnsward/remove_autoincrement
Remove sqlite specific`supports_autoincrement?` which defaults to true
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb | 11 | ||||
-rw-r--r-- | activerecord/test/schema/sqlite_specific_schema.rb | 7 |
2 files changed, 3 insertions, 15 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb index 997384daea..af38514e43 100644 --- a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb @@ -183,11 +183,6 @@ module ActiveRecord true end - # Returns true - def supports_autoincrement? #:nodoc: - true - end - def supports_index_sort_order? true end @@ -597,11 +592,7 @@ module ActiveRecord end def default_primary_key_type - if supports_autoincrement? - 'INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL' - else - 'INTEGER PRIMARY KEY NOT NULL' - end + 'INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL' end def translate_exception(exception, message) diff --git a/activerecord/test/schema/sqlite_specific_schema.rb b/activerecord/test/schema/sqlite_specific_schema.rb index e9ddeb32cf..b7aff4f47d 100644 --- a/activerecord/test/schema/sqlite_specific_schema.rb +++ b/activerecord/test/schema/sqlite_specific_schema.rb @@ -1,9 +1,6 @@ ActiveRecord::Schema.define do - # For sqlite 3.1.0+, make a table with an autoincrement column - if supports_autoincrement? - create_table :table_with_autoincrement, :force => true do |t| - t.column :name, :string - end + create_table :table_with_autoincrement, :force => true do |t| + t.column :name, :string end execute "DROP TABLE fk_test_has_fk" rescue nil |