aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYosuke Kabuto <bluewhale1982@gmail.com>2016-07-02 21:46:52 +0900
committerYosuke Kabuto <bluewhale1982@gmail.com>2016-07-02 23:58:14 +0900
commitb76f82d714e590c20370e72fa36fa574c4f17650 (patch)
tree09fad3494ff02f6705416338d083c46bfe4219bd
parent49fe7c66874b7b92ff1587b35777a760ac75be9b (diff)
downloadrails-b76f82d714e590c20370e72fa36fa574c4f17650.tar.gz
rails-b76f82d714e590c20370e72fa36fa574c4f17650.tar.bz2
rails-b76f82d714e590c20370e72fa36fa574c4f17650.zip
Update CHANGELOG.md for #25628 [ci skip]
Move new CHANGELOG entry top [ci skip] Remove parameter "options = nil" for #clear
-rw-r--r--activesupport/CHANGELOG.md6
-rw-r--r--activesupport/lib/active_support/cache.rb2
-rw-r--r--activesupport/lib/active_support/cache/file_store.rb2
-rw-r--r--activesupport/lib/active_support/cache/strategy/local_cache.rb6
4 files changed, 11 insertions, 5 deletions
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
index db439b5732..35bc30d736 100644
--- a/activesupport/CHANGELOG.md
+++ b/activesupport/CHANGELOG.md
@@ -1,3 +1,9 @@
+* Remove unused parameter `options = nil` for `#clear` of
+ `ActiveSupport::Cache::Strategy::LocalCache::LocalStore` and
+ `ActiveSupport::Cache::Strategy::LocalCache`.
+
+ *Yosuke Kabuto*
+
* Support parsing JSON time in ISO8601 local time strings in
`ActiveSupport::JSON.decode` when `parse_json_times` is enabled.
Strings in the format of `YYYY-MM-DD hh:mm:ss` (without a `Z` at
diff --git a/activesupport/lib/active_support/cache.rb b/activesupport/lib/active_support/cache.rb
index 179ca13b49..a095d8664d 100644
--- a/activesupport/lib/active_support/cache.rb
+++ b/activesupport/lib/active_support/cache.rb
@@ -464,7 +464,7 @@ module ActiveSupport
# The options hash is passed to the underlying cache implementation.
#
# All implementations may not support this method.
- def clear(options = nil)
+ def clear
raise NotImplementedError.new("#{self.class.name} does not support clear")
end
diff --git a/activesupport/lib/active_support/cache/file_store.rb b/activesupport/lib/active_support/cache/file_store.rb
index 99c55b1aa4..3c31e633c4 100644
--- a/activesupport/lib/active_support/cache/file_store.rb
+++ b/activesupport/lib/active_support/cache/file_store.rb
@@ -27,7 +27,7 @@ module ActiveSupport
# Deletes all items from the cache. In this case it deletes all the entries in the specified
# file store directory except for .keep or .gitkeep. Be careful which directory is specified in your
# config file when using +FileStore+ because everything in that directory will be deleted.
- def clear(options = nil)
+ def clear
root_dirs = exclude_from(cache_path, EXCLUDED_DIRS + GITKEEP_FILES)
FileUtils.rm_r(root_dirs.collect{|f| File.join(cache_path, f)})
rescue Errno::ENOENT
diff --git a/activesupport/lib/active_support/cache/strategy/local_cache.rb b/activesupport/lib/active_support/cache/strategy/local_cache.rb
index 1c678dc2af..f86cebe548 100644
--- a/activesupport/lib/active_support/cache/strategy/local_cache.rb
+++ b/activesupport/lib/active_support/cache/strategy/local_cache.rb
@@ -44,7 +44,7 @@ module ActiveSupport
yield
end
- def clear(options = nil)
+ def clear
@data.clear
end
@@ -78,9 +78,9 @@ module ActiveSupport
local_cache_key)
end
- def clear(options = nil) # :nodoc:
+ def clear # :nodoc:
return super unless cache = local_cache
- cache.clear(options)
+ cache.clear
super
end