aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2019-03-11 13:52:56 +0100
committerGitHub <noreply@github.com>2019-03-11 13:52:56 +0100
commitb3e6d5fa36c047ea826ad03f90a801f53c3b6820 (patch)
tree32c3a4e3d22b35ecead3c51941462d007a2ec44d
parent2440bef949fdb7ebdbe7cecdf2d56a99c5df25d1 (diff)
parent503c64704e41c1d2b05f9aefba2715e6c9d5a58f (diff)
downloadrails-b3e6d5fa36c047ea826ad03f90a801f53c3b6820.tar.gz
rails-b3e6d5fa36c047ea826ad03f90a801f53c3b6820.tar.bz2
rails-b3e6d5fa36c047ea826ad03f90a801f53c3b6820.zip
Merge pull request #35565 from yahonda/rm_test_create_table_with_custom_sequence_name
Remove `MigrationTest#test_create_table_with_custom_sequence_name`
-rw-r--r--activerecord/test/cases/migration_test.rb33
1 files changed, 0 insertions, 33 deletions
diff --git a/activerecord/test/cases/migration_test.rb b/activerecord/test/cases/migration_test.rb
index 0ecd93412e..788c8c36b8 100644
--- a/activerecord/test/cases/migration_test.rb
+++ b/activerecord/test/cases/migration_test.rb
@@ -567,39 +567,6 @@ class MigrationTest < ActiveRecord::TestCase
end
end
- if current_adapter? :OracleAdapter
- def test_create_table_with_custom_sequence_name
- # table name is 29 chars, the standard sequence name will
- # be 33 chars and should be shortened
- assert_nothing_raised do
- Person.connection.create_table :table_with_name_thats_just_ok do |t|
- t.column :foo, :string, null: false
- end
- ensure
- Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
- end
-
- # should be all good w/ a custom sequence name
- assert_nothing_raised do
- Person.connection.create_table :table_with_name_thats_just_ok,
- sequence_name: "suitably_short_seq" do |t|
- t.column :foo, :string, null: false
- end
-
- Person.connection.execute("select suitably_short_seq.nextval from dual")
-
- ensure
- Person.connection.drop_table :table_with_name_thats_just_ok,
- sequence_name: "suitably_short_seq" rescue nil
- end
-
- # confirm the custom sequence got dropped
- assert_raise(ActiveRecord::StatementInvalid) do
- Person.connection.execute("select suitably_short_seq.nextval from dual")
- end
- end
- end
-
def test_decimal_scale_without_precision_should_raise
e = assert_raise(ArgumentError) do
Person.connection.create_table :test_decimal_scales, force: true do |t|