diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2018-06-30 17:58:02 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-06-30 17:58:02 +0900 |
commit | b3653aee947a5f8c3a298913e539493d17c1932b (patch) | |
tree | 15876fe49c35e3e5c5f7bf5a940bbbffd85e5c02 | |
parent | 8ae3d17c9275cf65ec5891f046ad512bb9e8f9bd (diff) | |
parent | e862ee86b736f222d52202767f1d060defe0c766 (diff) | |
download | rails-b3653aee947a5f8c3a298913e539493d17c1932b.tar.gz rails-b3653aee947a5f8c3a298913e539493d17c1932b.tar.bz2 rails-b3653aee947a5f8c3a298913e539493d17c1932b.zip |
Merge pull request #33257 from utilum/ruby-warnings
Fix Ruby warnings tickled by the test suite
-rw-r--r-- | activejob/test/support/queue_classic/inline.rb | 7 | ||||
-rw-r--r-- | activejob/test/support/sneakers/inline.rb | 3 | ||||
-rw-r--r-- | activemodel/test/models/visitor.rb | 3 |
3 files changed, 8 insertions, 5 deletions
diff --git a/activejob/test/support/queue_classic/inline.rb b/activejob/test/support/queue_classic/inline.rb index ca3cd4581b..0695a34c27 100644 --- a/activejob/test/support/queue_classic/inline.rb +++ b/activejob/test/support/queue_classic/inline.rb @@ -1,22 +1,23 @@ # frozen_string_literal: true require "queue_classic" +require "active_support/core_ext/module/redefine_method" module QC class Queue - def enqueue(method, *args) + redefine_method(:enqueue) do |method, *args| receiver_str, _, message = method.rpartition(".") receiver = eval(receiver_str) receiver.send(message, *args) end - def enqueue_in(seconds, method, *args) + redefine_method(:enqueue_in) do |seconds, method, *args| receiver_str, _, message = method.rpartition(".") receiver = eval(receiver_str) receiver.send(message, *args) end - def enqueue_at(not_before, method, *args) + redefine_method(:enqueue_at) do |not_before, method, *args| receiver_str, _, message = method.rpartition(".") receiver = eval(receiver_str) receiver.send(message, *args) diff --git a/activejob/test/support/sneakers/inline.rb b/activejob/test/support/sneakers/inline.rb index 92b69ee3bc..e772c68c6e 100644 --- a/activejob/test/support/sneakers/inline.rb +++ b/activejob/test/support/sneakers/inline.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true require "sneakers" +require "active_support/core_ext/module/redefine_method" module Sneakers module Worker module ClassMethods - def enqueue(msg) + redefine_method(:enqueue) do |msg| worker = new(nil, nil, {}) worker.work(*msg) end diff --git a/activemodel/test/models/visitor.rb b/activemodel/test/models/visitor.rb index 9da004ffcc..96bf3ef10a 100644 --- a/activemodel/test/models/visitor.rb +++ b/activemodel/test/models/visitor.rb @@ -8,5 +8,6 @@ class Visitor has_secure_password(validations: false) - attr_accessor :password_digest, :password_confirmation + attr_accessor :password_digest + attr_reader :password_confirmation end |