aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael França <rafaelmfranca@gmail.com>2017-06-27 17:34:28 -0400
committerGitHub <noreply@github.com>2017-06-27 17:34:28 -0400
commitab600b1a9268dd5fb00ecccc97f258bcf1c0119d (patch)
tree201afde6801e9ae43953e37f10f6d3952d828465
parent7f9986237f45a9e771562470bbba629881d0f4aa (diff)
parent2508c7de267794781efb6d5f61d293c650d3d6e5 (diff)
downloadrails-ab600b1a9268dd5fb00ecccc97f258bcf1c0119d.tar.gz
rails-ab600b1a9268dd5fb00ecccc97f258bcf1c0119d.tar.bz2
rails-ab600b1a9268dd5fb00ecccc97f258bcf1c0119d.zip
Merge pull request #29551 from Edouard-chin/integration-test-follow-redirect
Calling `follow_redirect!` does not reset the `html_document`:
-rw-r--r--actionpack/lib/action_dispatch/testing/integration.rb2
-rw-r--r--actionpack/test/controller/integration_test.rb12
2 files changed, 13 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/testing/integration.rb b/actionpack/lib/action_dispatch/testing/integration.rb
index 4973a8f2f2..f16647fac8 100644
--- a/actionpack/lib/action_dispatch/testing/integration.rb
+++ b/actionpack/lib/action_dispatch/testing/integration.rb
@@ -338,7 +338,7 @@ module ActionDispatch
@integration_session = nil
end
- %w(get post patch put head delete cookies assigns).each do |method|
+ %w(get post patch put head delete cookies assigns follow_redirect!).each do |method|
define_method(method) do |*args|
# reset the html_document variable, except for cookies/assigns calls
unless method == "cookies" || method == "assigns"
diff --git a/actionpack/test/controller/integration_test.rb b/actionpack/test/controller/integration_test.rb
index 72163ccd5e..cb282d4330 100644
--- a/actionpack/test/controller/integration_test.rb
+++ b/actionpack/test/controller/integration_test.rb
@@ -335,6 +335,18 @@ class IntegrationProcessTest < ActionDispatch::IntegrationTest
end
end
+ def test_redirect_reset_html_document
+ with_test_route_set do
+ get "/redirect"
+ previous_html_document = html_document
+
+ follow_redirect!
+
+ assert_response :ok
+ refute_same previous_html_document, html_document
+ end
+ end
+
def test_xml_http_request_get
with_test_route_set do
get "/get", xhr: true