diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2012-08-02 15:30:38 -0300 |
---|---|---|
committer | Santiago Pastorino <santiago@wyeworks.com> | 2012-08-02 15:39:18 -0300 |
commit | 9c1b1bd42ce00d43b7894daaf096eff9ee55aef1 (patch) | |
tree | 26c31a8dad48182708d86c01d23bc0c3d2fbbb4a | |
parent | 55e05d465df668cd057d320664a7168990b6d6fb (diff) | |
download | rails-9c1b1bd42ce00d43b7894daaf096eff9ee55aef1.tar.gz rails-9c1b1bd42ce00d43b7894daaf096eff9ee55aef1.tar.bz2 rails-9c1b1bd42ce00d43b7894daaf096eff9ee55aef1.zip |
Use `:data => { :confirm => "Text" }` syntax instead of `:confirm` at
the ERB scaffold generator.
We are trying to teach the data attributes as best practices and
`:confirm` will be deprecated in 4.0.
-rw-r--r-- | railties/CHANGELOG.md | 11 | ||||
-rw-r--r-- | railties/lib/rails/generators/erb/scaffold/templates/index.html.erb | 2 |
2 files changed, 9 insertions, 4 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 5bffe75244..2537993df3 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,16 +1,21 @@ ## Rails 3.2.8 ## -* No changes. +* ERB scaffold generator use the `:data => { :confirm => "Text" }` syntax instead of `:confirm`. + + *Rafael Mendonça França* + ## Rails 3.2.7 (Jul 26, 2012) ## -* Since Rails 3.2, use layout false to render no layout -* Use strict_args_position! if available from Thor +* Since Rails 3.2, use layout false to render no layout +* Use strict_args_position! if available from Thor + ## Rails 3.2.6 (Jun 12, 2012) ## * No changes. + ## Rails 3.2.4 (May 31, 2012) ## * Add hook for resource route's generator. *Santiago Pastorino* diff --git a/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb b/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb index 7b1a2a1841..a7c12b9026 100644 --- a/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb +++ b/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb @@ -17,7 +17,7 @@ <% end -%> <td><%%= link_to 'Show', <%= singular_table_name %> %></td> <td><%%= link_to 'Edit', edit_<%= singular_table_name %>_path(<%= singular_table_name %>) %></td> - <td><%%= link_to 'Destroy', <%= singular_table_name %>, <%= key_value :confirm, "'Are you sure?'" %>, <%= key_value :method, ":delete" %> %></td> + <td><%%= link_to 'Destroy', <%= singular_table_name %>, <%= key_value :method, ":delete" %>, <%= key_value :data, "{ #{key_value :confirm, "'Are you sure?'"} }" %> %></td> </tr> <%% end %> </table> |