aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGannon McGibbon <gannon.mcgibbon@gmail.com>2018-12-12 12:10:45 -0500
committerGannon McGibbon <gannon.mcgibbon@gmail.com>2018-12-12 12:12:51 -0500
commit9bf5545ef7ce13cfc55b35f7d160897dee5cbe0e (patch)
tree5adbf3aad2cb3a370f53d2e577142470e06f3c34
parent662f14814eacdc100d0cd511aa05db34119de18a (diff)
downloadrails-9bf5545ef7ce13cfc55b35f7d160897dee5cbe0e.tar.gz
rails-9bf5545ef7ce13cfc55b35f7d160897dee5cbe0e.tar.bz2
rails-9bf5545ef7ce13cfc55b35f7d160897dee5cbe0e.zip
Remove redundant suffixes on generated integration tests.
-rw-r--r--railties/CHANGELOG.md4
-rw-r--r--railties/lib/rails/generators/test_unit/integration/integration_generator.rb6
-rw-r--r--railties/test/generators/integration_test_generator_test.rb7
3 files changed, 17 insertions, 0 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md
index d2992dbbdb..7ccb06953b 100644
--- a/railties/CHANGELOG.md
+++ b/railties/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Remove redundant suffixes on generated integration tests.
+
+ *Gannon McGibbon*
+
* Fix boolean interaction in scaffold system tests.
*Gannon McGibbon*
diff --git a/railties/lib/rails/generators/test_unit/integration/integration_generator.rb b/railties/lib/rails/generators/test_unit/integration/integration_generator.rb
index ae307c5cd9..ba27ed329b 100644
--- a/railties/lib/rails/generators/test_unit/integration/integration_generator.rb
+++ b/railties/lib/rails/generators/test_unit/integration/integration_generator.rb
@@ -10,6 +10,12 @@ module TestUnit # :nodoc:
def create_test_files
template "integration_test.rb", File.join("test/integration", class_path, "#{file_name}_test.rb")
end
+
+ private
+
+ def file_name
+ @_file_name ||= super.sub(/_test\z/i, "")
+ end
end
end
end
diff --git a/railties/test/generators/integration_test_generator_test.rb b/railties/test/generators/integration_test_generator_test.rb
index 82791f1a27..2ec4895096 100644
--- a/railties/test/generators/integration_test_generator_test.rb
+++ b/railties/test/generators/integration_test_generator_test.rb
@@ -15,4 +15,11 @@ class IntegrationTestGeneratorTest < Rails::Generators::TestCase
run_generator %w(iguchi/integration)
assert_file "test/integration/iguchi/integration_test.rb", /class Iguchi::IntegrationTest < ActionDispatch::IntegrationTest/
end
+
+ def test_test_suffix_is_not_duplicated
+ run_generator %w(integration_test)
+
+ assert_no_file "test/integration/integration_test_test.rb"
+ assert_file "test/integration/integration_test.rb"
+ end
end