diff options
| author | Jeremy Kemper <jeremy@bitsweat.net> | 2005-11-08 21:39:13 +0000 |
|---|---|---|
| committer | Jeremy Kemper <jeremy@bitsweat.net> | 2005-11-08 21:39:13 +0000 |
| commit | 97f418ce022da6b5da9cf24779932820e947414d (patch) | |
| tree | 06ecd0c098ffdcedc9ad45ff3930e24178c74970 | |
| parent | 86aaa6e9886ec16a76618e819092d0748bbedd53 (diff) | |
| download | rails-97f418ce022da6b5da9cf24779932820e947414d.tar.gz rails-97f418ce022da6b5da9cf24779932820e947414d.tar.bz2 rails-97f418ce022da6b5da9cf24779932820e947414d.zip | |
Correct handling of complex order clauses with SQL Server limit emulation. Closes #2770.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
| -rw-r--r-- | activerecord/CHANGELOG | 2 | ||||
| -rw-r--r-- | activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb | 2 | ||||
| -rw-r--r-- | activerecord/test/finder_test.rb | 10 |
3 files changed, 13 insertions, 1 deletions
diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG index 0d371d43b7..5eb3098650 100644 --- a/activerecord/CHANGELOG +++ b/activerecord/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Correct handling of complex order clauses with SQL Server limit emulation. #2770 [Tom Ward <tom@popdog.net>, Matt B.] + * Correct whitespace problem in Oracle default column value parsing. #2788 [rick@rickbradley.com] * Destroy associated has_and_belongs_to_many records after all before_destroy callbacks but before destroy. This allows you to act on the habtm association as you please while preserving referential integrity. #2065 [larrywilliams1@gmail.com, sam.kirchmeier@gmail.com, elliot@townx.org, Jeremy Kemper] diff --git a/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb index de40780a5a..a91e1ca56f 100644 --- a/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/sqlserver_adapter.rb @@ -478,7 +478,7 @@ module ActiveRecord case order when /DESC/i then order.gsub(/DESC/i, "ASC") when /ASC/i then order.gsub(/ASC/i, "DESC") - else String.new(order).insert(-1, " DESC") + else String.new(order).split(',').join(' DESC,') + ' DESC' end end diff --git a/activerecord/test/finder_test.rb b/activerecord/test/finder_test.rb index dc3464727e..897657faeb 100644 --- a/activerecord/test/finder_test.rb +++ b/activerecord/test/finder_test.rb @@ -325,6 +325,16 @@ class FinderTest < Test::Unit::TestCase assert_equal 'fixture_9', last_two_developers.first.name end + def test_find_all_with_limit_and_offset_and_multiple_order_clauses + first_three_posts = Post.find :all, :order => 'author_id, id', :limit => 3, :offset => 0 + second_three_posts = Post.find :all, :order => ' author_id,id ', :limit => 3, :offset => 3 + last_posts = Post.find :all, :order => ' author_id, id ', :limit => 3, :offset => 6 + + assert_equal [[0,3],[1,1],[1,2]], first_three_posts.map { |p| [p.author_id, p.id] } + assert_equal [[1,4],[1,5],[1,6]], second_three_posts.map { |p| [p.author_id, p.id] } + assert_equal [[2,7]], last_posts.map { |p| [p.author_id, p.id] } + end + def test_find_all_with_join developers_on_project_one = Developer.find( :all, |