diff options
| author | Jon Moss <maclover7@users.noreply.github.com> | 2016-10-17 17:43:53 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-10-17 17:43:53 -0400 |
| commit | 8e76f6959efc44c8575b721fdf53d06ea9430fed (patch) | |
| tree | 0c75eb21d20c6efdbccef4aa90650f63c01f6cad | |
| parent | 6aa378400218404f1002177f5457e296079ae255 (diff) | |
| parent | f6cc4f5648f7003a41f8e1c488a399abe4c73568 (diff) | |
| download | rails-8e76f6959efc44c8575b721fdf53d06ea9430fed.tar.gz rails-8e76f6959efc44c8575b721fdf53d06ea9430fed.tar.bz2 rails-8e76f6959efc44c8575b721fdf53d06ea9430fed.zip | |
Merge pull request #26809 from alexcameron89/contributing_guide_typo
[ci skip] Fix typo in Guides: Contributing
| -rw-r--r-- | guides/source/contributing_to_ruby_on_rails.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index 5791e7a12a..830a546570 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -272,7 +272,7 @@ The above are guidelines - please use your best judgment in using them. For changes that might have an impact on performance, please benchmark your code and measure the impact. Please share the benchmark script you used as well -as the results. You should consider including these information in your commit +as the results. You should consider including this information in your commit message, which allows future contributors to easily verify your findings and determine if they are still relevant. (For example, future optimizations in the Ruby VM might render certain optimizations unnecessary.) |