diff options
| author | Yukio Mizuta <untidyhair@gmail.com> | 2014-09-13 18:17:54 -0700 |
|---|---|---|
| committer | Yukio Mizuta <untidyhair@gmail.com> | 2014-09-14 10:55:19 -0700 |
| commit | 8c9b3473427d865a7e34b0a2a7295456d2c52747 (patch) | |
| tree | b097c62889dd58461cc01fd6ebe6465dbc657678 | |
| parent | afc213773c71420f50ffbc5809303616cb09f504 (diff) | |
| download | rails-8c9b3473427d865a7e34b0a2a7295456d2c52747.tar.gz rails-8c9b3473427d865a7e34b0a2a7295456d2c52747.tar.bz2 rails-8c9b3473427d865a7e34b0a2a7295456d2c52747.zip | |
Use dynamic path for dummy app location in plugin's test_helper.rb
| -rw-r--r-- | railties/CHANGELOG.md | 5 | ||||
| -rw-r--r-- | railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb | 2 | ||||
| -rw-r--r-- | railties/test/generators/plugin_generator_test.rb | 5 |
3 files changed, 10 insertions, 2 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 7d6521b2a8..646d84f304 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,8 @@ +* Change the path of dummy app location in plugin's test_helper.rb for cases + you specify dummy_path option. + + *Yukio Mizuta* + * Fix a bug in the `gem` method for Rails templates when non-String options are used. diff --git a/railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb b/railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb index 1e26a313cd..40c83d063a 100644 --- a/railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb +++ b/railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb @@ -1,7 +1,7 @@ # Configure Rails Environment ENV["RAILS_ENV"] = "test" -require File.expand_path("../dummy/config/environment.rb", __FILE__) +require File.expand_path("../../<%= options[:dummy_path] -%>/config/environment.rb", __FILE__) require "rails/test_help" Rails.backtrace_cleaner.remove_silencers! diff --git a/railties/test/generators/plugin_generator_test.rb b/railties/test/generators/plugin_generator_test.rb index 985644e8af..645efa5daf 100644 --- a/railties/test/generators/plugin_generator_test.rb +++ b/railties/test/generators/plugin_generator_test.rb @@ -54,7 +54,7 @@ class PluginGeneratorTest < Rails::Generators::TestCase run_generator assert_file "README.rdoc", /Bukkits/ assert_no_file "config/routes.rb" - assert_file "test/test_helper.rb" + assert_file "test/test_helper.rb", /require.+test\/dummy\/config\/environment/ assert_file "test/bukkits_test.rb", /assert_kind_of Module, Bukkits/ end @@ -270,6 +270,7 @@ class PluginGeneratorTest < Rails::Generators::TestCase assert_file "spec/dummy" assert_file "spec/dummy/config/application.rb" assert_no_file "test/dummy" + assert_file "test/test_helper.rb", /require.+spec\/dummy\/config\/environment/ end def test_creating_dummy_application_with_different_name @@ -277,6 +278,7 @@ class PluginGeneratorTest < Rails::Generators::TestCase assert_file "spec/fake" assert_file "spec/fake/config/application.rb" assert_no_file "test/dummy" + assert_file "test/test_helper.rb", /require.+spec\/fake\/config\/environment/ end def test_creating_dummy_without_tests_but_with_dummy_path @@ -284,6 +286,7 @@ class PluginGeneratorTest < Rails::Generators::TestCase assert_file "spec/dummy" assert_file "spec/dummy/config/application.rb" assert_no_file "test" + assert_no_file "test/test_helper.rb" assert_file '.gitignore' do |contents| assert_match(/spec\/dummy/, contents) end |