diff options
| author | Koichi ITO <koic.ito@gmail.com> | 2017-11-10 10:37:45 +0900 |
|---|---|---|
| committer | Koichi ITO <koic.ito@gmail.com> | 2017-11-10 10:52:04 +0900 |
| commit | 8c5115f95daa86cc9e79d6ad5c1076fee0f70903 (patch) | |
| tree | 9e611068c3054cd192307870c4645bc8dd311dbf | |
| parent | 78fc8530d4aa3d5d82da78fc0a763ff1d0553121 (diff) | |
| download | rails-8c5115f95daa86cc9e79d6ad5c1076fee0f70903.tar.gz rails-8c5115f95daa86cc9e79d6ad5c1076fee0f70903.tar.bz2 rails-8c5115f95daa86cc9e79d6ad5c1076fee0f70903.zip | |
Bump RuboCop to 0.51.0
## Summary
RuboCop 0.51.0 was released.
https://github.com/bbatsov/rubocop/releases/tag/v0.51.0
And rubocop-0-51 channel is available in Code Climate.
https://github.com/codeclimate/codeclimate-rubocop/issues/109
This PR will bump RuboCop to 0.51.0 and fixes the following new
offenses.
```console
% bundle exec rubocop
Inspecting 2358 files
(snip)
Offenses:
actionpack/lib/action_controller/metal/http_authentication.rb:251:59: C:
Prefer double-quoted strings unless you need single quotes to avoid
extra backslashes for escaping.
[key.strip, value.to_s.gsub(/^"|"$/, "").delete('\'')]
^^^^
activesupport/test/core_ext/load_error_test.rb:8:39: C: Prefer
double-quoted strings unless you need single quotes to avoid extra
backslashes for escaping.
assert_raise(LoadError) { require 'no_this_file_don\'t_exist' }
^^^^^^^^^^^^^^^^^^^^^^^^^^^
2358 files inspected, 2 offenses detected
```
| -rw-r--r-- | .codeclimate.yml | 2 | ||||
| -rw-r--r-- | Gemfile.lock | 2 | ||||
| -rw-r--r-- | actionpack/lib/action_controller/metal/http_authentication.rb | 2 | ||||
| -rw-r--r-- | activesupport/test/core_ext/load_error_test.rb | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/.codeclimate.yml b/.codeclimate.yml index 1f4a1bb201..1f0f067c5b 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -1,7 +1,7 @@ engines: rubocop: enabled: true - channel: rubocop-0-50 + channel: rubocop-0-51 ratings: paths: diff --git a/Gemfile.lock b/Gemfile.lock index d0bfe589be..86f6ed3baf 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -415,7 +415,7 @@ GEM sinatra (>= 0.9.2) vegas (~> 0.1.2) retriable (3.1.1) - rubocop (0.50.0) + rubocop (0.51.0) parallel (~> 1.10) parser (>= 2.3.3.1, < 3.0) powerpack (~> 0.1) diff --git a/actionpack/lib/action_controller/metal/http_authentication.rb b/actionpack/lib/action_controller/metal/http_authentication.rb index 08d9b094f3..0c8132684a 100644 --- a/actionpack/lib/action_controller/metal/http_authentication.rb +++ b/actionpack/lib/action_controller/metal/http_authentication.rb @@ -248,7 +248,7 @@ module ActionController def decode_credentials(header) ActiveSupport::HashWithIndifferentAccess[header.to_s.gsub(/^Digest\s+/, "").split(",").map do |pair| key, value = pair.split("=", 2) - [key.strip, value.to_s.gsub(/^"|"$/, "").delete('\'')] + [key.strip, value.to_s.gsub(/^"|"$/, "").delete("'")] end] end diff --git a/activesupport/test/core_ext/load_error_test.rb b/activesupport/test/core_ext/load_error_test.rb index 4fdd228ff8..41b11d0c33 100644 --- a/activesupport/test/core_ext/load_error_test.rb +++ b/activesupport/test/core_ext/load_error_test.rb @@ -5,7 +5,7 @@ require "active_support/core_ext/load_error" class TestLoadError < ActiveSupport::TestCase def test_with_require - assert_raise(LoadError) { require 'no_this_file_don\'t_exist' } + assert_raise(LoadError) { require "no_this_file_don't_exist" } end def test_with_load assert_raise(LoadError) { load "nor_does_this_one" } |