diff options
| author | Godfrey Chan <godfreykfc@gmail.com> | 2014-10-21 00:35:44 -0700 |
|---|---|---|
| committer | Godfrey Chan <godfreykfc@gmail.com> | 2014-10-21 00:35:44 -0700 |
| commit | 87e10ca33910075dc39333a4c9fa7b02e3480298 (patch) | |
| tree | ad7398a80ee46faac09a0962dd47ccfd57088163 | |
| parent | f1e189410124acc5cd3c84c6b3d992ae3f00c962 (diff) | |
| parent | 8aa51b5def26aaedd8b91c2adb686f6fb6cf78a4 (diff) | |
| download | rails-87e10ca33910075dc39333a4c9fa7b02e3480298.tar.gz rails-87e10ca33910075dc39333a4c9fa7b02e3480298.tar.bz2 rails-87e10ca33910075dc39333a4c9fa7b02e3480298.zip | |
Merge pull request #17336 from rebyn/patch-1
Provide more reasoning to not accept cosmetic changes [ci skip]
| -rw-r--r-- | guides/source/contributing_to_ruby_on_rails.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index 302c4ca9c0..7b2eaed900 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -193,7 +193,7 @@ Now get busy and add/edit code. You're on your branch now, so you can write what * Update the (surrounding) documentation, examples elsewhere, and the guides: whatever is affected by your contribution. -TIP: Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted. +TIP: Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted (read more about [our rationales behind this decision](https://github.com/rails/rails/pull/13771#issuecomment-32746700). #### Follow the Coding Conventions |