diff options
| author | Aaron Patterson <aaron.patterson@gmail.com> | 2015-09-21 14:00:52 -0700 |
|---|---|---|
| committer | Aaron Patterson <aaron.patterson@gmail.com> | 2015-09-21 14:00:52 -0700 |
| commit | 7cdb2ec9636288dce25836c3ec0f261537a6425f (patch) | |
| tree | 81fced35d151ab60fb26b3f35c2f21328928cc29 | |
| parent | f9dda1567ea8d5b27bd9d66ac5a8b43dc67a6b7e (diff) | |
| download | rails-7cdb2ec9636288dce25836c3ec0f261537a6425f.tar.gz rails-7cdb2ec9636288dce25836c3ec0f261537a6425f.tar.bz2 rails-7cdb2ec9636288dce25836c3ec0f261537a6425f.zip | |
remove `blank?` calls on `==`
Since Mime::Type implements `method_missing`, and `blank?` triggers it's
positive branch:
https://github.com/rails/rails/blob/f9dda1567ea8d5b27bd9d66ac5a8b43dc67a6b7e/actionpack/lib/action_dispatch/http/mime_type.rb#L342
We should stop calling `blank?`.
| -rw-r--r-- | actionpack/lib/action_dispatch/http/mime_type.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/http/mime_type.rb b/actionpack/lib/action_dispatch/http/mime_type.rb index a25b6c8883..2d49ad661c 100644 --- a/actionpack/lib/action_dispatch/http/mime_type.rb +++ b/actionpack/lib/action_dispatch/http/mime_type.rb @@ -313,7 +313,7 @@ to: end def ==(mime_type) - return false if mime_type.blank? + return false unless mime_type (@synonyms + [ self ]).any? do |synonym| synonym.to_s == mime_type.to_s || synonym.to_sym == mime_type.to_sym end |