diff options
| author | Carl Lerche <carllerche@mac.com> | 2009-05-26 15:19:39 -0700 |
|---|---|---|
| committer | Carl Lerche <carllerche@mac.com> | 2009-05-26 15:19:39 -0700 |
| commit | 7211048b2b1d640c4f33587b57261bdfe9c77b93 (patch) | |
| tree | 4b0cfb4959eeb50280793e4f6354a3bda2cae6b9 | |
| parent | a1f280e83d2b134e23897d4de457d76fb0095768 (diff) | |
| download | rails-7211048b2b1d640c4f33587b57261bdfe9c77b93.tar.gz rails-7211048b2b1d640c4f33587b57261bdfe9c77b93.tar.bz2 rails-7211048b2b1d640c4f33587b57261bdfe9c77b93.zip | |
Get all template tests passing on new base
| -rw-r--r-- | actionpack/Rakefile | 3 | ||||
| -rw-r--r-- | actionpack/lib/action_controller/new_base/base.rb | 2 | ||||
| -rw-r--r-- | actionpack/test/template/body_parts_test.rb | 5 |
3 files changed, 6 insertions, 4 deletions
diff --git a/actionpack/Rakefile b/actionpack/Rakefile index c44c88f638..5f5614e58f 100644 --- a/actionpack/Rakefile +++ b/actionpack/Rakefile @@ -64,8 +64,7 @@ Rake::TestTask.new(:test_new_base_on_old_tests) do |t| # ==== Not ported # * filters - # Dir.glob( "test/{dispatch,template}/**/*_test.rb" ).sort + - t.test_files = Dir.glob( "test/{dispatch}/**/*_test.rb" ).sort + %w( + t.test_files = Dir.glob( "test/{dispatch,template}/**/*_test.rb" ).sort + %w( action_pack_assertions addresses_render assert_select base benchmark caching capture content_type cookie dispatcher filter_params flash helper http_basic_authentication diff --git a/actionpack/lib/action_controller/new_base/base.rb b/actionpack/lib/action_controller/new_base/base.rb index ffe608ade4..3477fc0403 100644 --- a/actionpack/lib/action_controller/new_base/base.rb +++ b/actionpack/lib/action_controller/new_base/base.rb @@ -40,7 +40,7 @@ module ActionController module ImplicitRender def process_action(method_name) ret = super - default_render if response_body.nil? + default_render unless performed? ret end diff --git a/actionpack/test/template/body_parts_test.rb b/actionpack/test/template/body_parts_test.rb index e17092a452..4e7aa63f96 100644 --- a/actionpack/test/template/body_parts_test.rb +++ b/actionpack/test/template/body_parts_test.rb @@ -4,6 +4,9 @@ class BodyPartsTest < ActionController::TestCase RENDERINGS = [Object.new, Object.new, Object.new] class TestController < ActionController::Base + def performed? + defined?(ActionController::Http) ? true : super + end def index RENDERINGS.each do |rendering| @template.punctuate_body! rendering @@ -16,7 +19,7 @@ class BodyPartsTest < ActionController::TestCase def test_body_parts get :index - pending do + pending(:old_base) do # TestProcess buffers body_parts into body # TODO: Rewrite test w/o going through process assert_equal RENDERINGS, @response.body_parts |