aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJosé Valim <jose.valim@gmail.com>2012-01-06 09:03:09 +0100
committerJosé Valim <jose.valim@gmail.com>2012-01-06 09:03:24 +0100
commit705b29bcb15f940294f17645ad91c02731f6861a (patch)
treee7e27590bb1d6098bc15fd296a8e237a9f61f8df
parent291ad6318fdd028292d47d05a99fdc059e3b2bfc (diff)
downloadrails-705b29bcb15f940294f17645ad91c02731f6861a.tar.gz
rails-705b29bcb15f940294f17645ad91c02731f6861a.tar.bz2
rails-705b29bcb15f940294f17645ad91c02731f6861a.zip
Revert "Merge pull request #2325 from pyromaniac/master"
It breaks the build for mysql. This reverts commit 958d25df4a1b0d41ce5deeeb0739c93b49bbd18d, reversing changes made to 8f309e31057e1b26fefedb199ab0526126fb1fe4.
-rw-r--r--activerecord/lib/active_record/validations/uniqueness.rb2
-rw-r--r--activerecord/test/cases/validations/uniqueness_validation_test.rb12
2 files changed, 1 insertions, 13 deletions
diff --git a/activerecord/lib/active_record/validations/uniqueness.rb b/activerecord/lib/active_record/validations/uniqueness.rb
index cbeb95718c..8abe001775 100644
--- a/activerecord/lib/active_record/validations/uniqueness.rb
+++ b/activerecord/lib/active_record/validations/uniqueness.rb
@@ -52,7 +52,7 @@ module ActiveRecord
def build_relation(klass, table, attribute, value) #:nodoc:
column = klass.columns_hash[attribute.to_s]
- value = column.limit ? value.to_s[0, column.limit] : value.to_s if value && column.text?
+ value = column.limit ? value.to_s[0, column.limit] : value.to_s if column.text?
if !options[:case_sensitive] && value && column.text?
# will use SQL LOWER function before comparison, unless it detects a case insensitive collation
diff --git a/activerecord/test/cases/validations/uniqueness_validation_test.rb b/activerecord/test/cases/validations/uniqueness_validation_test.rb
index 327830096b..382ad0a06a 100644
--- a/activerecord/test/cases/validations/uniqueness_validation_test.rb
+++ b/activerecord/test/cases/validations/uniqueness_validation_test.rb
@@ -45,18 +45,6 @@ class UniquenessValidationTest < ActiveRecord::TestCase
assert t2.save, "Should now save t2 as unique"
end
- def test_validates_uniqueness_with_nil_value
- Topic.validates_uniqueness_of(:title)
-
- t = Topic.new("title" => nil)
- assert t.save, "Should save t as unique"
-
- t2 = Topic.new("title" => nil)
- assert !t2.valid?, "Shouldn't be valid"
- assert !t2.save, "Shouldn't save t2 as unique"
- assert_equal ["has already been taken"], t2.errors[:title]
- end
-
def test_validates_uniqueness_with_validates
Topic.validates :title, :uniqueness => true
Topic.create!('title' => 'abc')