diff options
| author | Eileen M. Uchitelle <eileencodes@gmail.com> | 2016-06-30 13:57:28 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-06-30 13:57:28 -0400 |
| commit | 6cd338f50092ddf75f5bd4ca80e01dc719898716 (patch) | |
| tree | de0ae2fdbc8eca57ec260294a4726fd442959222 | |
| parent | b96bd9c4cbdeec0f8076344a5a946ef3ee828f76 (diff) | |
| parent | 21a5841b1f28dfb548dc69d89bb17dbc89cac950 (diff) | |
| download | rails-6cd338f50092ddf75f5bd4ca80e01dc719898716.tar.gz rails-6cd338f50092ddf75f5bd4ca80e01dc719898716.tar.bz2 rails-6cd338f50092ddf75f5bd4ca80e01dc719898716.zip | |
Merge pull request #25609 from rosenfeld/patch-8
Add a Rails 5 release note for ActionController::Live becoming a Concern
| -rw-r--r-- | guides/source/5_0_release_notes.md | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/guides/source/5_0_release_notes.md b/guides/source/5_0_release_notes.md index 3832109987..e90a205d0f 100644 --- a/guides/source/5_0_release_notes.md +++ b/guides/source/5_0_release_notes.md @@ -447,6 +447,17 @@ Please refer to the [Changelog][action-pack] for detailed changes. `stale?`. ([Pull Request](https://github.com/rails/rails/pull/18374)) +* `ActionController::Live` became an `ActiveSupport::Concern`. That + means it can't be just included in other modules without extending + them with `ActiveSupport::Concern` or `ActionController::Live` + won't take effect in production. Some people may be using another + module to include some special `Warden`/`Devise` authentication + failure handling code as well since the middleware can't catch a + `:warden` thrown by a spawned thread which is the case when using + `ActionController::Live`. + ([More details in this issue](https://github.com/rails/rails/issues/25581)) + + Action View ------------- |