aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeremy Kemper <jeremykemper@gmail.com>2014-10-03 15:39:58 -0700
committerJeremy Kemper <jeremykemper@gmail.com>2014-10-03 15:39:58 -0700
commit657ce17868b0eba89680b8e215fded0e3d53a685 (patch)
treee36970421aa9e35273cd99a738d784112d57ccc5
parentcefb00aac632f10817b63ef42309df9ecc3103ea (diff)
parentafb92754c86372d34b36f8a3d340277c21a9c0e8 (diff)
downloadrails-657ce17868b0eba89680b8e215fded0e3d53a685.tar.gz
rails-657ce17868b0eba89680b8e215fded0e3d53a685.tar.bz2
rails-657ce17868b0eba89680b8e215fded0e3d53a685.zip
Merge pull request #17150 from effektz/tr-instead-of-gsub
Use #tr instead of #gsub where possible
-rw-r--r--actionview/lib/action_view/helpers/form_tag_helper.rb2
-rw-r--r--actionview/lib/action_view/template.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/actionview/lib/action_view/helpers/form_tag_helper.rb b/actionview/lib/action_view/helpers/form_tag_helper.rb
index 7d1cdc5a68..ff5d278b85 100644
--- a/actionview/lib/action_view/helpers/form_tag_helper.rb
+++ b/actionview/lib/action_view/helpers/form_tag_helper.rb
@@ -862,7 +862,7 @@ module ActionView
# see http://www.w3.org/TR/html4/types.html#type-name
def sanitize_to_id(name)
- name.to_s.delete(']').gsub(/[^-a-zA-Z0-9:.]/, "_")
+ name.to_s.delete(']').tr('^-a-zA-Z0-9:.', "_")
end
end
end
diff --git a/actionview/lib/action_view/template.rb b/actionview/lib/action_view/template.rb
index f398f9bfa3..379f31bdaf 100644
--- a/actionview/lib/action_view/template.rb
+++ b/actionview/lib/action_view/template.rb
@@ -321,7 +321,7 @@ module ActionView
end
def identifier_method_name #:nodoc:
- inspect.gsub(/[^a-z_]/, '_')
+ inspect.tr('^a-z_', '_')
end
def instrument(action, &block)