Fixed log file permissions to be 666 instead of 777 (so they're not executable) #471 [Lucas Carlson]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

5 files changed, 7 insertions, 5 deletions

diff --git a/railties/CHANGELOG b/railties/CHANGELOG
index bd94159061..e5de3dc999 100644
--- a/railties/CHANGELOG
+++ b/railties/CHANGELOG
@@ -1,5 +1,7 @@
 *SVN*
 
+* Fixed log file permissions to be 666 instead of 777 (so they're not executable) #471 [Lucas Carlson]
+
 * Fixed that auto reloading would some times not work or would reload the models twice #475 [Tobias Luetke]
 
 * Added rewrite rules to deal with caching to public/.htaccess
diff --git a/railties/Rakefile b/railties/Rakefile
index 43723af8a2..ae82f5870c 100644
--- a/railties/Rakefile
+++ b/railties/Rakefile
@@ -79,7 +79,7 @@ task :initialize_log_files do
   LOG_FILES.each do |log_file|
     log_path = File.join(log_dir, log_file)
     touch log_path
-    chmod 0777, log_path
+    chmod 0666, log_path
   end
 end
 
diff --git a/railties/doc/index.html b/railties/doc/index.html
index 522a88cd5c..0cc0ecf9d4 100644
--- a/railties/doc/index.html
+++ b/railties/doc/index.html
@@ -32,7 +32,7 @@
 <p><b>Before you move on</b>, verify that the following conditions have been met:</p>
 
 <ol>
-  <li>The log directory and the empty log files must be writable to the web server (<code>chmod -R 777 log</code>).
+  <li>The log directory and the empty log files must be writable to the web server (<code>chmod -R 666 log/*</code>).
   <li>
     The shebang line in the public/dispatch* files must reference your Ruby installation. <br/>
     You might need to change it to <code>#!/usr/bin/env ruby</code> or point directly at the installation.
@@ -67,4 +67,4 @@
 </p>
 
 </body>
-</html>
\ No newline at end of file
+</html>
diff --git a/railties/environments/shared.rb b/railties/environments/shared.rb
index c4d52d4b26..8e36ae6670 100644
--- a/railties/environments/shared.rb
+++ b/railties/environments/shared.rb
@@ -47,7 +47,7 @@ rescue StandardError
   RAILS_DEFAULT_LOGGER = Logger.new(STDERR)
   RAILS_DEFAULT_LOGGER.level = Logger::WARN
   RAILS_DEFAULT_LOGGER.warn(
-    "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0777. " +
+    "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0666. " +
     "The log level has been raised to WARN and the output directed to STDERR until the problem is fixed."
   )
 end
diff --git a/railties/environments/shared_for_gem.rb b/railties/environments/shared_for_gem.rb
index 82a5d3295c..a277641a99 100644
--- a/railties/environments/shared_for_gem.rb
+++ b/railties/environments/shared_for_gem.rb
@@ -44,7 +44,7 @@ rescue StandardError
   RAILS_DEFAULT_LOGGER = Logger.new(STDERR)
   RAILS_DEFAULT_LOGGER.level = Logger::WARN
   RAILS_DEFAULT_LOGGER.warn(
-    "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0777. " +
+    "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0666. " +
     "The log level has been raised to WARN and the output directed to STDERR until the problem is fixed."
   )
 end