diff options
| author | Raghu Kamat <rkamat@teladoc.com> | 2018-10-25 09:13:39 -0400 |
|---|---|---|
| committer | Raghu Kamat <rkamat@teladoc.com> | 2018-10-25 16:00:59 -0400 |
| commit | 5edbc1fd2034f79e41638d8e67324c7d357002d6 (patch) | |
| tree | 6fcd3461f592553190ac5163c0b48c0269354a58 | |
| parent | a3dcba42e2422eb9c2e77011a39ce72dc934b420 (diff) | |
| download | rails-5edbc1fd2034f79e41638d8e67324c7d357002d6.tar.gz rails-5edbc1fd2034f79e41638d8e67324c7d357002d6.tar.bz2 rails-5edbc1fd2034f79e41638d8e67324c7d357002d6.zip | |
Added maxlength example to text_field documentation
The usage of maxlength in the text_field helper adds a size attribute
to the generated text_field input with the same value as the maxlength.
This implicit addition of size attribute by the method gives a false
impression that it may be bug. By adding the implementation of the
maxlength to the api docs, we explicitly tell the reader referring the
api doc that addition of size along with maxlength is the expected behaviour.
[ci skip]
| -rw-r--r-- | actionview/lib/action_view/helpers/form_helper.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/actionview/lib/action_view/helpers/form_helper.rb b/actionview/lib/action_view/helpers/form_helper.rb index 6e769aa560..c2caa77afb 100644 --- a/actionview/lib/action_view/helpers/form_helper.rb +++ b/actionview/lib/action_view/helpers/form_helper.rb @@ -1130,6 +1130,9 @@ module ActionView # text_field(:post, :title, class: "create_input") # # => <input type="text" id="post_title" name="post[title]" value="#{@post.title}" class="create_input" /> # + # text_field(:post, :title, maxlength: 30, class: "title_input") + # # => <input type="text" id="post_title" name="post[title]" maxlength="30" size="30" value="#{@post.title}" class="title_input" /> + # # text_field(:session, :user, onchange: "if ($('#session_user').val() === 'admin') { alert('Your login cannot be admin!'); }") # # => <input type="text" id="session_user" name="session[user]" value="#{@session.user}" onchange="if ($('#session_user').val() === 'admin') { alert('Your login cannot be admin!'); }"/> # |