diff options
| author | Aaron Patterson <aaron.patterson@gmail.com> | 2010-09-12 19:22:19 -0700 |
|---|---|---|
| committer | Aaron Patterson <aaron.patterson@gmail.com> | 2010-09-12 19:22:19 -0700 |
| commit | 5ea98130038ff5395239f3f6e46dc9276d3198ec (patch) | |
| tree | 479df4a93436a6744bed63840c88c9cc43aab9bc | |
| parent | 6cd4e8f51ff231cafb2fdb6d71328f763c934b0b (diff) | |
| download | rails-5ea98130038ff5395239f3f6e46dc9276d3198ec.tar.gz rails-5ea98130038ff5395239f3f6e46dc9276d3198ec.tar.bz2 rails-5ea98130038ff5395239f3f6e46dc9276d3198ec.zip | |
OUTER JOIN should be LEFT OUTER JOIN
| -rw-r--r-- | lib/arel/visitors/join_sql.rb | 2 | ||||
| -rw-r--r-- | spec/arel/select_manager_spec.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/arel/visitors/join_sql.rb b/lib/arel/visitors/join_sql.rb index c1e00ea8f0..ab3d10f99c 100644 --- a/lib/arel/visitors/join_sql.rb +++ b/lib/arel/visitors/join_sql.rb @@ -21,7 +21,7 @@ module Arel end def visit_Arel_Nodes_OuterJoin o - "OUTER JOIN #{visit o.right} #{visit o.constraint}" + "LEFT OUTER JOIN #{visit o.right} #{visit o.constraint}" end def visit_Arel_Nodes_InnerJoin o diff --git a/spec/arel/select_manager_spec.rb b/spec/arel/select_manager_spec.rb index 02586f3a65..df8d236bc3 100644 --- a/spec/arel/select_manager_spec.rb +++ b/spec/arel/select_manager_spec.rb @@ -252,7 +252,7 @@ module Arel manager = Arel::SelectManager.new Table.engine manager.from Nodes::OuterJoin.new(table, aliaz, table[:id].eq(aliaz[:id])) manager.join_sql.should be_like %{ - OUTER JOIN "users" "users_2" "users"."id" = "users_2"."id" + LEFT OUTER JOIN "users" "users_2" "users"."id" = "users_2"."id" } check manager.joins(manager).should == manager.join_sql end |