diff options
| author | Aaron Patterson <aaron.patterson@gmail.com> | 2010-09-07 15:26:21 -0700 |
|---|---|---|
| committer | Aaron Patterson <aaron.patterson@gmail.com> | 2010-09-07 15:26:21 -0700 |
| commit | 5b480bc60bf5de2b90ba32e854b6a7d2955cbcbb (patch) | |
| tree | 4b17c74afc338b6b575d0f3ae90f6d44e4e2e23e | |
| parent | e614fcc03f13601421f3cac3d00ba3aeefa128c9 (diff) | |
| download | rails-5b480bc60bf5de2b90ba32e854b6a7d2955cbcbb.tar.gz rails-5b480bc60bf5de2b90ba32e854b6a7d2955cbcbb.tar.bz2 rails-5b480bc60bf5de2b90ba32e854b6a7d2955cbcbb.zip | |
OUTER joins should be LEFT outer joins
| -rw-r--r-- | lib/arel/visitors/to_sql.rb | 2 | ||||
| -rw-r--r-- | spec/arel/select_manager_spec.rb | 2 | ||||
| -rw-r--r-- | spec/arel/table_spec.rb | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/lib/arel/visitors/to_sql.rb b/lib/arel/visitors/to_sql.rb index b6ebee3c9e..4ac38fb13e 100644 --- a/lib/arel/visitors/to_sql.rb +++ b/lib/arel/visitors/to_sql.rb @@ -71,7 +71,7 @@ module Arel end def visit_Arel_Nodes_OuterJoin o - "#{visit o.left} OUTER JOIN #{visit o.right} #{visit o.constraint}" + "#{visit o.left} LEFT OUTER JOIN #{visit o.right} #{visit o.constraint}" end def visit_Arel_Nodes_InnerJoin o diff --git a/spec/arel/select_manager_spec.rb b/spec/arel/select_manager_spec.rb index 800018aa7d..0d7dc27571 100644 --- a/spec/arel/select_manager_spec.rb +++ b/spec/arel/select_manager_spec.rb @@ -82,7 +82,7 @@ module Arel manager.join(right, Nodes::OuterJoin).on(predicate) manager.to_sql.should be_like %{ SELECT FROM "users" - OUTER JOIN "users" "users_2" + LEFT OUTER JOIN "users" "users_2" ON "users"."id" = "users_2"."id" } end diff --git a/spec/arel/table_spec.rb b/spec/arel/table_spec.rb index 78705b4f0a..8e27d60078 100644 --- a/spec/arel/table_spec.rb +++ b/spec/arel/table_spec.rb @@ -21,7 +21,7 @@ module Arel mgr.to_sql.should be_like %{ SELECT FROM "users" - OUTER JOIN "users" "users_2" + LEFT OUTER JOIN "users" "users_2" ON "users"."id" = "users_2"."id" } end |