aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-03-31 09:45:44 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-03-31 09:52:02 +0900
commit51ab5cb0432c483422112ebbb274855a3fa5ecc8 (patch)
treeea293cfbd53106e08b36501536fefdb185fc31d0
parentaae8fd0e07a9e924838845c1b29960f598fc14f3 (diff)
downloadrails-51ab5cb0432c483422112ebbb274855a3fa5ecc8.tar.gz
rails-51ab5cb0432c483422112ebbb274855a3fa5ecc8.tar.bz2
rails-51ab5cb0432c483422112ebbb274855a3fa5ecc8.zip
Follow up tweaks b89a3e7e638a50c648a17d09c48b49b707e1d90d [ci skip]
* use backticks instead of `+` * and more (e.g. missed replacing `Array#excluding` and `Enumerable#excluding` in b89a3e7e638a50c648a17d09c48b49b707e1d90d)
-rw-r--r--actionpack/CHANGELOG.md4
-rw-r--r--activejob/CHANGELOG.md2
-rw-r--r--activerecord/CHANGELOG.md10
-rw-r--r--activesupport/CHANGELOG.md2
4 files changed, 9 insertions, 9 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
index 9931a0de81..79f6320a04 100644
--- a/actionpack/CHANGELOG.md
+++ b/actionpack/CHANGELOG.md
@@ -43,7 +43,7 @@
*Rafael Mendonça França*
-* Introduce ActionDispatch::HostAuthorization
+* Introduce `ActionDispatch::HostAuthorization`.
This is a new middleware that guards against DNS rebinding attacks by
explicitly permitting the hosts a request can be made to.
@@ -73,7 +73,7 @@
* Raise an error on root route naming conflicts.
- Raises an ArgumentError when multiple root routes are defined in the
+ Raises an `ArgumentError` when multiple root routes are defined in the
same context instead of assigning nil names to subsequent roots.
*Gannon McGibbon*
diff --git a/activejob/CHANGELOG.md b/activejob/CHANGELOG.md
index e09ba4b055..138c8a8ef4 100644
--- a/activejob/CHANGELOG.md
+++ b/activejob/CHANGELOG.md
@@ -34,7 +34,7 @@
*Edouard Chin*
-* Restore HashWithIndifferentAccess support to ActiveJob::Arguments.deserialize.
+* Restore `HashWithIndifferentAccess` support to `ActiveJob::Arguments.deserialize`.
*Gannon McGibbon*
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 432ac641c6..37f31462b3 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -348,7 +348,7 @@
*Gannon McGibbon*
-* Cached columns_hash fields should be excluded from ResultSet#column_types
+* Cached `columns_hash` fields should be excluded from `ResultSet#column_types`.
PR #34528 addresses the inconsistent behaviour when attribute is defined for an ignored column. The following test
was passing for SQLite and MySQL, but failed for PostgreSQL:
@@ -379,12 +379,12 @@
* Make the implicit order column configurable.
- When calling ordered finder methods such as +first+ or +last+ without an
+ When calling ordered finder methods such as `first` or `last` without an
explicit order clause, ActiveRecord sorts records by primary key. This can
result in unpredictable and surprising behaviour when the primary key is
not an auto-incrementing integer, for example when it's a UUID. This change
makes it possible to override the column used for implicit ordering such
- that +first+ and +last+ will return more predictable results.
+ that `first` and `last` will return more predictable results.
Example:
@@ -530,10 +530,10 @@
* Enum raises on invalid definition values
- When defining a Hash enum it can be easy to use [] instead of {}. This
+ When defining a Hash enum it can be easy to use `[]` instead of `{}`. This
commit checks that only valid definition values are provided, those can
be a Hash, an array of Symbols or an array of Strings. Otherwise it
- raises an ArgumentError.
+ raises an `ArgumentError`.
Fixes #33961
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
index 6eb0af69bf..db9c7e96f3 100644
--- a/activesupport/CHANGELOG.md
+++ b/activesupport/CHANGELOG.md
@@ -61,7 +61,7 @@
*Kaan Ozkan*, *Sharang Dashputre*
-* Allow Array#excluding and Enumerable#excluding to deal with a passed array gracefully.
+* Allow `Array#excluding` and `Enumerable#excluding` to deal with a passed array gracefully.
[ 1, 2, 3, 4, 5 ].excluding([4, 5]) # => [ 1, 2, 3 ]