diff options
| author | Aaron Patterson <aaron.patterson@gmail.com> | 2016-08-26 15:48:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-08-26 15:48:51 -0700 |
| commit | 4e0ce3d6a5a6db0d59661733c65dff84b25c8384 (patch) | |
| tree | f5c3da0376140e35b036abdbe977363fd017c79e | |
| parent | 09827f361d4bc73e6ff157d9feb74a465e4e4cdd (diff) | |
| parent | 63d180c96ff0096d417c6ddac56ec074a51e41a5 (diff) | |
| download | rails-4e0ce3d6a5a6db0d59661733c65dff84b25c8384.tar.gz rails-4e0ce3d6a5a6db0d59661733c65dff84b25c8384.tar.bz2 rails-4e0ce3d6a5a6db0d59661733c65dff84b25c8384.zip | |
Merge pull request #444 from alassek/dot-visitor-bind-param
Fix invalid BindParam output in Dot visitor
| -rw-r--r-- | lib/arel/visitors/dot.rb | 3 | ||||
| -rw-r--r-- | test/visitors/test_dot.rb | 6 |
2 files changed, 8 insertions, 1 deletions
diff --git a/lib/arel/visitors/dot.rb b/lib/arel/visitors/dot.rb index ca8d2b0bd0..31e4a66a1f 100644 --- a/lib/arel/visitors/dot.rb +++ b/lib/arel/visitors/dot.rb @@ -204,7 +204,6 @@ module Arel alias :visit_NilClass :visit_String alias :visit_TrueClass :visit_String alias :visit_FalseClass :visit_String - alias :visit_Arel_Nodes_BindParam :visit_String alias :visit_Integer :visit_String alias :visit_Fixnum :visit_String alias :visit_BigDecimal :visit_String @@ -212,6 +211,8 @@ module Arel alias :visit_Symbol :visit_String alias :visit_Arel_Nodes_SqlLiteral :visit_String + def visit_Arel_Nodes_BindParam o; end + def visit_Hash o o.each_with_index do |pair, i| edge("pair_#{i}") { visit pair } diff --git a/test/visitors/test_dot.rb b/test/visitors/test_dot.rb index 4dc3c9c6c5..6db9b9b6de 100644 --- a/test/visitors/test_dot.rb +++ b/test/visitors/test_dot.rb @@ -70,6 +70,12 @@ module Arel @visitor.accept binary, Collectors::PlainString.new end end + + def test_Arel_Nodes_BindParam + node = Arel::Nodes::BindParam.new + collector = Collectors::PlainString.new + assert_match '[label="<f0>Arel::Nodes::BindParam"]', @visitor.accept(node, collector).value + end end end end |