diff options
| author | Eileen M. Uchitelle <eileencodes@users.noreply.github.com> | 2017-06-02 14:50:51 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-02 14:50:51 -0400 |
| commit | 3d31c05254fafd0aad556728ae85efc30ae1a272 (patch) | |
| tree | 503b95287c844efed0fc4d8e98ad9c30134366f8 | |
| parent | e935a6c0be7d7732d2459e84c77c40bd4932b42c (diff) | |
| parent | 2b394c843f9d6fc866d5a37ca8dae73fc629a08f (diff) | |
| download | rails-3d31c05254fafd0aad556728ae85efc30ae1a272.tar.gz rails-3d31c05254fafd0aad556728ae85efc30ae1a272.tar.bz2 rails-3d31c05254fafd0aad556728ae85efc30ae1a272.zip | |
Merge pull request #29324 from koic/remove_redundant_test_find_all_with_join
Remove the redundant `test_find_all_with_join` in AR
| -rw-r--r-- | activerecord/test/cases/finder_test.rb | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/activerecord/test/cases/finder_test.rb b/activerecord/test/cases/finder_test.rb index 4837a169fa..420f552ef6 100644 --- a/activerecord/test/cases/finder_test.rb +++ b/activerecord/test/cases/finder_test.rb @@ -1023,16 +1023,6 @@ class FinderTest < ActiveRecord::TestCase assert_raise(ActiveRecord::StatementInvalid) { Topic.find_by_sql "select 1 from badtable" } end - def test_find_all_with_join - developers_on_project_one = Developer. - joins("LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id"). - where("project_id=1").to_a - assert_equal 3, developers_on_project_one.length - developer_names = developers_on_project_one.map(&:name) - assert_includes developer_names, "David" - assert_includes developer_names, "Jamis" - end - def test_joins_dont_clobber_id first = Firm. joins("INNER JOIN companies clients ON clients.firm_id = companies.id"). |