Fix modification of input on *_any/*_all predications

2 files changed, 18 insertions, 0 deletions

diff --git a/lib/arel/predications.rb b/lib/arel/predications.rb
index 58f02a2b53..920a9ee374 100644
--- a/lib/arel/predications.rb
+++ b/lib/arel/predications.rb
@@ -163,6 +163,7 @@ module Arel
     private
 
     def grouping_any method_id, others
+      others = others.dup
       first = send method_id, others.shift
 
       Nodes::Grouping.new others.inject(first) { |memo,expr|
@@ -171,6 +172,7 @@ module Arel
     end
 
     def grouping_all method_id, others
+      others = others.dup
       first = send method_id, others.shift
 
       Nodes::Grouping.new others.inject(first) { |memo,expr|
diff --git a/test/attributes/test_attribute.rb b/test/attributes/test_attribute.rb
index df7dc69621..352774071a 100644
--- a/test/attributes/test_attribute.rb
+++ b/test/attributes/test_attribute.rb
@@ -366,6 +366,14 @@ module Arel
             SELECT "users"."id" FROM "users" WHERE ("users"."id" = 1 OR "users"."id" = 2)
           }
         end
+
+        it 'should not eat input' do
+          relation = Table.new(:users)
+          mgr = relation.project relation[:id]
+          values = [1,2]
+          mgr.where relation[:id].eq_any(values)
+          values.must_equal [1,2]
+        end
       end
 
       describe '#eq_all' do
@@ -382,6 +390,14 @@ module Arel
             SELECT "users"."id" FROM "users" WHERE ("users"."id" = 1 AND "users"."id" = 2)
           }
         end
+
+        it 'should not eat input' do
+          relation = Table.new(:users)
+          mgr = relation.project relation[:id]
+          values = [1,2]
+          mgr.where relation[:id].eq_all(values)
+          values.must_equal [1,2]
+        end
       end
 
       describe '#matches' do